Remove boost::recursive_wrapper
usage from JsValue
#2345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
It's expected that upon adoption of C++17, USD will replace
boost::variant
withstd::variant
. However,std::variant
does not supportboost::recursive_wrapper
and does not have an equivalent concept.This PR introduces
Js_Wrapper
, internally leveragingstd::unique_ptr
, but adds the invariant that it is always dereferenceable (ie. always non-NULL) and implements equality operators via the dereferenced value not the pointer value.Js_Wrapper
can then be used to add a level of indirection toJsValue::_Holder
for types (JsObject
andJsArray
) that may containJsValue
s.This PR adds test coverage for an array of objects nested in an object to validate both conversion and equality testing for more complicated structures.
Fixes Issue(s)
N/A