Replace boost::filter_iterator with explicit iterator implementation
#2312
Conversation
nvmkuruc
force-pushed
the
sdffilteriterator
branch
from
daa8cb8
to
2d2e524
Compare
|
Filed as internal issue #USD-8056 |
nvmkuruc
force-pushed
the
sdffilteriterator
branch
from
2d2e524
to
465d5db
Compare
nvmkuruc
force-pushed
the
sdffilteriterator
branch
from
465d5db
to
1997562
Compare
| const _Owner* _owner; | ||
| void filter() | ||
| { | ||
| while (_underlyingIterator != _end && |
There was a problem hiding this comment.
I'm pretty sure you have this inverted. According to the boost filter_iterator documentation, the iterator retains the element if the predicate returns true and skips the element if the predicate is false. Here, you're skipping when the predicate is true.
There was a problem hiding this comment.
That was it. All tests are now passing.
|
|
||
| bool operator()(const value_type& x) const | ||
| private: | ||
| // Skip any iterators that don't satisfy the predicate |
There was a problem hiding this comment.
These shouldFilter and filter functions aren't here for API conformance right? If I'm right, they should follow our coding conventions for private methods, i.e. capitalized and starting with an underscore
| using pointer = typename _InnerIterator::pointer; | ||
| using difference_type = typename _InnerIterator::difference_type; | ||
|
|
||
| _FilterIterator() = default; |
There was a problem hiding this comment.
The body of all three of these should be on a new line like you did for all the rest of the functions.
nvmkuruc
force-pushed
the
sdffilteriterator
branch
from
1997562
to
bce13c5
Compare
Description of Change(s)
Converts the
_Predicateprivate class into an explicit_FilterIteratorbidirectional iterator implementation.Fixes Issue(s)
boost::filter_iteratorusage with fully specified iterator class #2311