Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace boost::totally_ordered with explicit operator overloads for PcpLayerStackIdentifier #2270

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Replace boost::totally_ordered with explicit operator overloads for PcpLayerStackIdentifier #2270

merged 2 commits into from
Jul 3, 2023

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Feb 13, 2023 •
edited
Loading

Description of Change(s)

  • Add explicit implementations of operator<=, operator>, operator>=, and operator!= to PcpLayerStackIdentifier

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-8008

crevilla
crevilla reviewed Jun 20, 2023
View reviewed changes
pxr/usd/pcp/layerStackIdentifier.h
@@ -77,8 +74,13 @@ class PcpLayerStackIdentifier :
// Comparison.
PCP_API
bool operator==(const This &rhs) const;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline implementations should be on a new line like you've done in all the other changes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@pixar-oss pixar-oss merged commit fd7c450 into PixarAnimationStudios:dev Jul 3, 2023
@nvmkuruc nvmkuruc deleted the pcpidentifierordered branch December 29, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crevilla crevilla crevilla left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nvmkuruc @tallytalwar @crevilla @pixar-oss