Replace boost::iterator_adaptor with explicitly specified iterator definition for UsdNotice::ObjectsChanged::PathRange
#2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-8007 |
nvmkuruc
force-pushed
the
usdnoticeadaptor
branch
from
6d1d337
to
a766269
Compare
nvmkuruc
force-pushed
the
usdnoticeadaptor
branch
from
a766269
to
5810559
Compare
crevilla
reviewed
Jul 24, 2023
| @@ -171,15 +194,22 @@ class UsdNotice { | |||
| /// details. | |||
| USD_API bool HasChangedFields() const; | |||
|
|
|||
There was a problem hiding this comment.
Per our discussion, it'll be better to include a deprecated base() function that returns the underlyingIterator to maintain downstream compatibility in the meantime.
…definition for `UsdNotice::ObjectsChanged::PathRange`
nvmkuruc
force-pushed
the
usdnoticeadaptor
branch
from
5810559
to
1c2f8fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
_UnderlyingIteratortype alias for_PathsToChangesMap::const_iteratorinUsdNotice::ObjectsChanged::PathRange::iteratorUsdNotice::ObjectsChanged::PathRange::iteratorGetBasemethod to the iterator for direct query of the underlying iteratorFixes Issue(s)
boost::iterator_adaptorusage with fully specified iterator classes #2228