APPLE: Prevent mipmapping of 1x1 textures. #2264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-8000 |
creijon
force-pushed
the
jon/dev/mipmap_check
branch
2 times, most recently
from
9f6e682
to
1b92063
Compare
creijon
force-pushed
the
jon/dev/mipmap_check
branch
from
1b92063
to
4bac140
Compare
creijon
force-pushed
the
jon/dev/mipmap_check
branch
from
4bac140
to
5590b7b
Compare
creijon
force-pushed
the
jon/dev/mipmap_check
branch
2 times, most recently
from
119779a
to
7136fb4
Compare
creijon
force-pushed
the
jon/dev/mipmap_check
branch
from
7136fb4
to
10bcda9
Compare
creijon
force-pushed
the
jon/dev/mipmap_check
branch
2 times, most recently
from
b00efec
to
7acb0b4
Compare
creijon
force-pushed
the
jon/dev/mipmap_check
branch
from
6bd328e
to
846ec7d
Compare
creijon
force-pushed
the
jon/dev/mipmap_check
branch
from
846ec7d
to
7f0f519
Compare
creijon
force-pushed
the
jon/dev/mipmap_check
branch
from
7f0f519
to
5cdcf9d
Compare
pixar-oss
pushed a commit
that referenced
this pull request
Jun 21, 2023
In Metal, if a texture has all dimensions being a single texel big the mipmapping call `generateMipmapsForTexture` will fail and throw an exception. So we add a check to the existing one in `HgiMetalBlitCmds::GenerateMipMaps()` which catches this. Thanks to @Morteeza for this. Contribution: Apple Fixes #2264 (Internal change: 2281900)
|
This PR was merged into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
In Metal, if a texture has any dimension being a single texel big the mipmapping call
generateMipmapsForTexturewill fail and throw an exception. So we add a check to the existing one inHgiMetalBlitCmds::GenerateMipMaps()which catches this.Thanks to @Morteeza for this.
Fixes Issue(s)