Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[usdMaya] Loading the shading mode plugins. #226

Conversation

sirpalee
Copy link
Contributor

This PR is a general improvement for the shading mode exporter plugin interface.

  • Previously there was no functionality to load the plugins. I added a function similar to the primWriter plugin loading code, that's run before any of the exporters are accessed.
  • The default values caused a bit of confusion. The GPrim Colors -> displayColor remapping was missing from the export code (both the translator and the usdExport call).
  • A request to an invalid export appended empty exporter to the list with the same name. This problem was fixed by accessing the exporter through an iterator rather than std::map's operator[].
  • If the manual export command was used instead of the file translator, the shading mode worked incorrectly. The shading modes were accessible by their internal names, which are not documented anywhere. I added support for the custom names on the file/export interface.

@jtran56
Copy link

jtran56 commented Jun 21, 2017

Filed as internal issue #147855.

@sirpalee sirpalee force-pushed the pr/loading_shading_mode_plugs branch from b04d4dc to e9d3ef8 Compare June 30, 2017 06:33
@sirpalee
Copy link
Contributor Author

Note the original commit mixed up GPrim Colors and Material Colors shading mode, and exported them incorrectly. The PR was updated.

@sirpalee sirpalee force-pushed the pr/loading_shading_mode_plugs branch from e9d3ef8 to bc4356d Compare June 30, 2017 06:40
@pixar-oss pixar-oss merged commit bc4356d into PixarAnimationStudios:dev Sep 28, 2017
pixar-oss added a commit that referenced this pull request Sep 28, 2017
[usdMaya] Loading the shading mode plugins.
@sirpalee sirpalee deleted the pr/loading_shading_mode_plugs branch January 23, 2018 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants