Replace boost::equality_comparable with explicit implementation of operator!= in pxr/usd/sdf
#2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-7965 |
nvmkuruc
force-pushed
the
sdfequality
branch
from
f55e121
to
f772db0
Compare
…`operator!=` in `pxr/usd/sdf`
crevilla
reviewed
Jun 20, 2023
| @@ -146,6 +143,7 @@ struct SdfNamespaceEditDetail : | |||
| const std::string& reason); | |||
|
|
|||
| SDF_API bool operator==(const SdfNamespaceEditDetail& rhs) const; | |||
There was a problem hiding this comment.
Just a nitpick. Since == uses "rhs", != should use "rhs" too
crevilla
reviewed
Jun 20, 2023
| Sdf.NamespaceEdit('/A', '/B'), | ||
| "reason" | ||
| ) | ||
| self.assertTrue(prototype == prototype) |
There was a problem hiding this comment.
The prototype == prototype test case would be more robust if it were
self.assertTrue(prototype == Sdf.NamespaceEditDetail(
 Sdf.NamespaceEditDetail.Okay,
 Sdf.NamespaceEdit('/A', '/B'),
 "reason"
 )
Same for !=
There was a problem hiding this comment.
Done, I also switched the tests to use assertEqual and assertNotEqual which is preferred per https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertFalse
nvmkuruc
force-pushed
the
sdfequality
branch
2 times, most recently
from
c4ef3f8
to
47e6cb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
operator!=toSdfAllowed,SdfChildrenProxy,SdfNamespaceEdit,SdfNamespaceEditDetail, andSdfUnregisteredValueSdf.NamespaceEdit,Sdf.NamespaceEditDetail, andSdf.UnregisteredValue.Fixes Issue(s)
boost::equality_comparablecan be replaced with explicitoperator!=implementation #2236