Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::noncopyable with explicit deletion of copy constructor and assignment operator in pxr/usd/sdf and pxr/usd/pcp #2208

Merged
merged 1 commit into from
May 11, 2023

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Jan 26, 2023

Description of Change(s)

  • PcpMapExpression::_Node, Sdf_ChangeManager, Sdf_FileFormatRegistry, Sdf_IdentityRegistry, Sdf_LayerRegistry, SdfLayerTree, Sdf_ListEditor, SdfNamespaceEdit_Namespace, SdfPath::_Entry, SdfValueTypeRegistry, Sdf_MemoryFlexBuffer, SdfSchemaBase have been updated to use explicit deletion of the copy constructor and assignment operator. pxr/usd/pcp/mapExpression.h was getting its include of boost::noncopyable indirectly from pxr/usd/sdf which is why its included in this change.
  • A spurious include of boost/noncopyable.hpp in pxr/usd/sdf/pathNode.h has been removed

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@sunyab
Copy link
Contributor

sunyab commented Jan 27, 2023

Filed as internal issue #USD-7927

… and assignment operator in pxr/usd/sdf and pxr/usd/pcp
@pixar-oss pixar-oss merged commit 4e5ff41 into PixarAnimationStudios:dev May 11, 2023
@nvmkuruc nvmkuruc deleted the sdfnoncopyable branch December 1, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants