[usdSkel] testUsdSkelBakeSkinning - only do usda diff on x86_64 arch #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...as floating point precision issues may result in differences on other architectures. (ie, the test would fail on linux aarch64 hardware) This change follows the pattern from testUsdDancingCubesExample: https://github.com/PixarAnimationStudios/USD/blob/4ee62b99c91afbea38f2afd855fbd21cb23d6e64/extras/usd/examples/usdDancingCubesExample/CMakeLists.txt#L37
This was referenced Jan 11, 2023
|
Filed as internal issue #USD-7867 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
...as floating point precision issues may result in differences on other architectures.
(ie, the test would fail on linux aarch64 hardware)
This change follows the pattern from testUsdDancingCubesExample:
https://github.com/PixarAnimationStudios/USD/blob/4ee62b99c91afbea38f2afd855fbd21cb23d6e64/extras/usd/examples/usdDancingCubesExample/CMakeLists.txt#L37
For more aarch64 related fixes, also see:
Fixes Issue(s)
Failure of testUsdSkelBakeSkinning on aarch64 hardware
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement