Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Unicode UTF-8 Identifiers #2120

Closed

Commits on Dec 2, 2022

  1. Support for Unicode UTF-8 Identifiers

    - Added additional lexer / parser for UTF-8 Identifiers
    - Added TF setting to scope changes behind TF_UTF8_IDENTIFIERS
    - Made first pass at Tf string methods to switch on setting
      and use ASCII vs. Unicode validation rules
    - Enabled different rules for identifiers vs. prim names
      (validation for prim names falls back to identifiers
      when under ASCII rules)
    - Added UCA sorting for UTF-8 strings and tests against
      Unicode conformance tests
    - Pulled common parse layer methods out of textFileFormat
      parser to enable use by both ASCII and Unicode flavors
    - Added support for Unicode UTF-8 identifiers / prim names
      in usdGenSchema
    erslavin committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    2fd8dc4 View commit details
    Browse the repository at this point in the history
  2. Support for Unicode UTF-8 Identifiers

    - Added missing files generated by new scripts to cache
      unicode character class data
    erslavin committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    2125720 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Unicode UTF-8 Identifiers

    - Implemented chosen sort algorithm
      Lexicographic ASCII + UTF-8 Byte Ordering
    - Removed all functionality related to UCA
    - Removed all functionality for case mapping
    - Adjusted tests to reflect original ordering that did not change
      with new algorithm
    - Added documentation notes where appropriate for Tf string methods
      that should only be used in ASCII-only circumstances
    erslavin committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    3ad7117 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Support for Unicode UTF-8 Identifiers

    - Lofted up TfMakeValidPrimName / TfIsValidPrimName to Sdf
    erslavin committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    aa922ca View commit details
    Browse the repository at this point in the history
  2. Support for Unicode UTF-8 Identifiers

    - Removed overly restrictive comments on certain TfString
      methods and documented specific restrictions
    - Added TF_DEV_AXIOM statements where required to validate
      those specific restrictions
    erslavin committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    fc4094a View commit details
    Browse the repository at this point in the history
  3. Support for Unicode UTF-8 Identifiers

    - Changed default setting for TF_UTF8_IDENTIFIERS to `true`, enabling
      new Unicode code paths by default
    erslavin committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    80cd511 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Support for Unicode UTF-8 Identifiers

    - Changed logic for ASCII checks to check leading bit
    - Leveraged ASCII check in _LessImpl
    - Removed TF_UTF8_IDENTIFIERS from header - all access goes through
      UseUTF8Identifiers which checks value of TF_UTF8_IDENTIFIERS
    - Fixed typo on TfDictionaryLessThan
    - Removed specific overload for checking valid prim name regardless
      of TF_UTF8_IDENTIFIERS value
    erslavin committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    6cd2c68 View commit details
    Browse the repository at this point in the history
  2. Support for Unicode UTF-8 Identifiers

    - Placed appropriate parser objects back in PXR namespace
    erslavin committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    cf26251 View commit details
    Browse the repository at this point in the history
  3. Support for Unicode UTF-8 Identifiers

    - Placed appropriate objects back in PXR namespace
    - Modified yy files to ensure they emit proper parser context object
      for yyparse
    erslavin committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    1c6d5b6 View commit details
    Browse the repository at this point in the history
  4. Support for Unicode UTF-8 Identifiers

    - Removed empty line in comment
    erslavin committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    eb6c633 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Support for Unicode UTF-8 Identifiers

    - Changed IsValidUTF8PrimName to IsValidUTF8Name
    - Removed TF_API from several inlined methods
    erslavin committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    5d26bf3 View commit details
    Browse the repository at this point in the history
  2. Support for Unicode UTF-8 Identifiers

    - Refactored naming methods to streamline implementation
    - Added comment to test to indicate long term treatment
      if runtime switch is removed
    erslavin committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    60aea0b View commit details
    Browse the repository at this point in the history
  3. Support for Unicode UTF-8 Identifiers

    - Refactored XID_Start / Continue methods to take code point
    - Refactored usage of these methods to pass code point
      via dereferenced iterator
    erslavin committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    f106196 View commit details
    Browse the repository at this point in the history