Add CLI11 to Tf #2107
Merged
Add CLI11 to Tf #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgovil
added a commit
to dgovil/USD
that referenced
this pull request
Nov 28, 2022
This was referenced Nov 28, 2022
Merged
Merged
|
Filed as internal issue #USD-7796 |
This was referenced Nov 29, 2022
|
Hey @dgovil, just a heads-up: we've merged this PR internally but during review wound up making some changes to more fully isolate the CLI11 in Tf by adding extra compile-time checks and a hardcoded Practically, this means the other PRs that build against Tf's CLI11 will need to have something like |
|
Thanks for the headsup, Sunya! It's much appreciated.
…On Wed, 7 Dec 2022 at 15:44, Sunya Boonyatera ***@***.***> wrote:
Hey @dgovil <https://github.com/dgovil>, just a heads-up: we've merged
this PR internally but during review wound up making some changes to more
fully isolate the CLI11 in Tf by adding extra compile-time checks and a
hardcoded pxr_CLI namespace along with the normal pxr namespace. These
are to guard against the unlikely-but-possible cases where USD's embedded
CLI11 might conflict with another version of CLI11 in user code.
Practically, this means the other PRs that build against Tf's CLI11 will
need to have something like using namespace pxr_CLI added. I'm adding
that in as I merge the other PRs, but wanted to let you know FYI.
—
Reply to this email directly, view it on GitHub
<#2107 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABB4XUQAA3DEICZJSGCR5QTWMEOO7ANCNFSM6AAAAAASNU3DJU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This PR adds CLI11 to
Tfunder thepxr/base/tf/pxrCLI11in thePXR_NSnamespace.This splits out the addition of the library in #2090 per the notes there.