Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[usdview] add --camera cmdline arg #210

Merged

Conversation

pmolodo
Copy link
Contributor

@pmolodo pmolodo commented May 6, 2017

Description of Change(s)

Allows choosing of what camera to use when opening the scene

Included Commit(s)

Fixes Issue(s)

  • None, perse, but there was a TODO note about not hardcoding the default to be a pixar-specific name, which this effectively does

Copy link
Contributor

@sunyab sunyab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing along some code review notes:

Hi Paul,
This is great! The one limitation is that there may commonly be multiple cameras in the scene with the same (prim) name. I'd suggest allowing (and documenting) --camera to accept either a simple name or a full prim path, then matching by name or path, as appropriate, in mainWindow.py . (Owning also that the camera menu has the same issue - if there are multiple cameras with the same name you'll see the name repeated but won't know which is which - needs fixing!)

Thanks - I know alot of folks are going to find this really useful!

@pmolodo
Copy link
Contributor Author

pmolodo commented May 8, 2017

Added in the ability for the command-line arg to take full prim paths, as requested. Didn't touch the handling of duplicate camera names in the UI menu - will let you folks decide how you want to deal with that.

Lemme know if you need anything else!

@jtran56
Copy link

jtran56 commented Jun 2, 2017

Filed as internal issue #147138.

@sunyab sunyab changed the base branch from master to dev June 9, 2017 18:25
@pixar-oss pixar-oss merged commit 7fa19c8 into PixarAnimationStudios:dev Jun 9, 2017
pixar-oss added a commit that referenced this pull request Jun 9, 2017
@pmolodo pmolodo deleted the usdview_camera_cmdline branch March 12, 2019 23:03
AdamFelt pushed a commit to autodesk-forks/USD that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants