Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPLE: Fix for crash on loading non-filterable textures #2048

Closed

Conversation

creijon
Copy link
Contributor

@creijon creijon commented Sep 21, 2022

Description of Change(s)

In Metal, several of the texture formats don't support filtering, so the call to generateMipmapsForTexture with fail with an exception on pipeline validation.

Fixes Issue(s)

  • Crashing when loading U16 textures etc.
  • I have submitted a signed Contributor License Agreement

@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-7655

@creijon creijon force-pushed the jon/dev/fix_mipmap_crash branch 2 times, most recently from d76def6 to a731915 Compare September 30, 2022 19:25
@creijon creijon force-pushed the jon/dev/fix_mipmap_crash branch from a731915 to 76ef7bc Compare October 18, 2022 19:55
@creijon creijon force-pushed the jon/dev/fix_mipmap_crash branch from 76ef7bc to 8ab3b5c Compare October 29, 2022 13:52
@creijon creijon force-pushed the jon/dev/fix_mipmap_crash branch 2 times, most recently from a4c615a to e9eae1e Compare November 9, 2022 18:38
@creijon creijon force-pushed the jon/dev/fix_mipmap_crash branch from e9eae1e to 9246c07 Compare November 17, 2022 13:02
@creijon creijon force-pushed the jon/dev/fix_mipmap_crash branch from 9246c07 to 31109bb Compare November 25, 2022 09:53
@creijon creijon force-pushed the jon/dev/fix_mipmap_crash branch 2 times, most recently from 0ba95da to fbe323c Compare December 3, 2022 06:58
@creijon creijon force-pushed the jon/dev/fix_mipmap_crash branch from fbe323c to 98aa572 Compare December 10, 2022 07:36
@creijon creijon force-pushed the jon/dev/fix_mipmap_crash branch from 98aa572 to 5e9cbc2 Compare January 6, 2023 13:30
@creijon creijon force-pushed the jon/dev/fix_mipmap_crash branch from 5e9cbc2 to 72e4699 Compare January 16, 2023 21:54
pixar-oss added a commit that referenced this pull request Jan 27, 2023
APPLE: Fix for crash on loading non-filterable textures

(Internal change: 2259813)
@creijon creijon closed this Jan 30, 2023
@creijon creijon force-pushed the jon/dev/fix_mipmap_crash branch from 72e4699 to 98ef4ec Compare January 30, 2023 08:34
@creijon creijon deleted the jon/dev/fix_mipmap_crash branch January 30, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants