Fix bad include path for OSD headers. #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current (3.0.5) OSD build puts its headers into <install_path>/include/opensubdiv, **not** into <install_path>/include/opensubdiv3...
|
Thanks mont29 -- we have this fixed on our end too and we'll be pushing it soon. Incidentally, do we have a CLA from you? Thanks again! |
|
Thanks for the answer @c64kernal . |
|
Great, thanks so much! |
|
Our change was pushed through. Closing. Thanks again! |
asluk
pushed a commit
to NVIDIAGameWorks/USD
that referenced
this pull request
Apr 4, 2020
…ionStudios#20) * [USD] changed FILE* to ArchFile* for binary save/load * Fixes for Debug build * Memory Storage (working but not final version) * Memory storage fixes & cleanups * Implemented file mapping for ReadOnly memory storage * Fix for array diff in USD text format * Test for usd diff refactored (added command args parsing and write to diff.usda)
This was referenced Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current (3.0.5) OSD build puts its headers into
<install_path>/include/opensubdiv, not into<install_path>/include/opensubdiv3...I guess this comes from dev env where you have several versions of OSD installed, but... not nice for common case. ;)