Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the AppendDiscoveryResult to NdrRegistry #1810

Merged
merged 2 commits into from
Jun 25, 2022
Merged

Add the AppendDiscoveryResult to NdrRegistry #1810

merged 2 commits into from
Jun 25, 2022

Commits on Jun 14, 2022

  1. Add the AppendDiscoveryResult to NdrRegistry 

    This method allows the client to explicitly set additional discovery
results that would NOT be found through the plugin system. For example
to support lazily-loaded plugins which cannot be easily discovered in
advance.
    @diegojesus-fn @DuncanHopkins
    diegojesus-fn authored and DuncanHopkins committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    594857e View commit details
    Browse the repository at this point in the history

  2. Rename AppendDiscoveryResult methods to AddDiscoveryResult 

    Append implies that discovery results are stored in a list while add is
more generic and does not expose implementation details.

This commit also improves these methods' documentation.
    @diegojesus-fn @DuncanHopkins
    diegojesus-fn authored and DuncanHopkins committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    aca3e7c View commit details
    Browse the repository at this point in the history