create single token for "usdVariantSet_" #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was a string constant USD_VARIANT_SET_PREFIX in referenceAssembly.cpp, and _tokens->VariantSetPlugNamePrefix in translatorModelAssembly
pixar-oss
added a commit
that referenced
this pull request
May 13, 2017
create single token for "usdVariantSet_"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The same string constant - the prefix before attribute names used to select variant sets - was defined in two different places: as
USD_VARIANT_SET_PREFIXinreferenceAssembly, and_tokens->VariantSetPlugNamePrefixintranslatorModelAssembly. It caused some initial confusion, so I decided to unify onPxrUsdMayaVariantSetTokensinreferenceAssembly. (I placed it inreferenceAssembly, becausetranslatorModelAssemblyalready includesreferenceAssembly, but not vice-versa.)Included Commit(s)
Fixes Issue(s)