Fix UDIM resolution for symlinks pointing to non-UDIM textures. #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-6352 |
|
Per #1329, I'm closing this PR out in favor of a pending change that just removes the symlink processing altogether. Thanks! |
kohakukun
added a commit
to autodesk-forks/USD
that referenced
this pull request
Oct 21, 2024
* OGSMOD-4153: Fix OIT for hgiWebGPU - Implement early fragment test directly in the shader when it is not supported by the graphics API. - Add a new test for OIT in usdImagingGL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Checks that the resolved path returned, has a valid UDIM tile name.
As I was writing up the description for #1329, it occurred to me that my solution solves our problem, but the whole idea of resolving the sym-links might just be totally broken, given that there could be two UDIM paths that resolve to the same first-tile, but diverge on subsequent tiles:
Fixes Issue(s)
#1329