Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF_MAKE_PP_{ARRAY,LIST,SEQ} and TF_PP_TUPLE_{SIZE,TO_LIST,TO_SEQ} are unused in pxr and introduce boost dependencies #2225

Closed
nvmkuruc opened this issue Jan 31, 2023 · 6 comments

Comments

@nvmkuruc
Copy link
Collaborator

Description of Issue

The following macros in preprocessorUtils.h are unused in pxr and introduce additional dependencies on BOOST_PP_EMPTY, BOOST_PP_TUPLE_TO_SEQ, and BOOST_PP_TUPLE_TO_LIST.

#define TF_PP_TUPLE_SIZE(tuple) \
#define TF_PP_TUPLE_TO_LIST(tuple) \
#define TF_PP_TUPLE_TO_SEQ(tuple) \
#define TF_MAKE_PP_ARRAY(...) \
#define TF_MAKE_PP_LIST(...) \
#define TF_MAKE_PP_SEQ(...) \

Steps to Reproduce

N/A

System Information (OS, Hardware)

N/A

Package Versions

N/A

Build Flags

N/A

@spiffmon
Copy link
Member

spiffmon commented Feb 1, 2023

The TF_MAKE_XXX macros are, in fact, unused in our entire codebase. The TF_PP_TUPLE_TO_XXX macros, however, are used in execution libraries that are likely to become part of OpenExec, so it's not immediately clear that moving them out of pxr now would be a win...

@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-7953

@nvmkuruc
Copy link
Collaborator Author

nvmkuruc commented Mar 1, 2023

The TF_MAKE_XXX macros are, in fact, unused in our entire codebase. The TF_PP_TUPLE_TO_XXX macros, however, are used in execution libraries that are likely to become part of OpenExec, so it's not immediately clear that moving them out of pxr now would be a win...

It's definitely something that can be waited on until the other preprocessor usage is addressed, but I might argue that there would still be a benefit to having a boost-free USD even if OpenExec wasn't.

@spiffmon
Copy link
Member

spiffmon commented Mar 2, 2023

The TF_MAKE_XXX macros are, in fact, unused in our entire codebase. The TF_PP_TUPLE_TO_XXX macros, however, are used in execution libraries that are likely to become part of OpenExec, so it's not immediately clear that moving them out of pxr now would be a win...

It's definitely something that can be waited on until the other preprocessor usage is addressed, but I might argue that there would still be a benefit to having a boost-free USD even if OpenExec wasn't.

An excellent point, @nvmkuruc , given that OpenExec is a ways out.

@nvmkuruc
Copy link
Collaborator Author

TF_NUM_ARGS can be added to the list of unused macros with the integration of #2530

pixar-oss added a commit that referenced this issue Mar 26, 2024
Fixes #2225

(Internal change: 2320843)
(Internal change: 2320872)
@nvmkuruc
Copy link
Collaborator Author

nvmkuruc commented Apr 8, 2024

@jesschimein @spiffmon @tallytalwar I think this can be closed now with 24.05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants