Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TfHashMap/Set version check incorrect, at least for clang #127

Closed
meshula opened this issue Dec 23, 2016 · 1 comment
Closed

TfHashMap/Set version check incorrect, at least for clang #127

meshula opened this issue Dec 23, 2016 · 1 comment

Comments

@meshula
Copy link
Member

meshula commented Dec 23, 2016

On clang we want to use the std::unordered_map version of TfHashMap and TfHashSet:

The failing version check reads as follows:

#elif __cplusplus > 201103L
// Use C++11 unordered_map.
#include <unordered_map>

But should read:

#elif __cplusplus >= 201103L
// Use C++11 unordered_map.
#include <unordered_map>

I am guessing that this test would hold true on other compilers...?

@meshula meshula changed the title TfHashMap version check incorrect, at least for clang TfHashMap/Set version check incorrect, at least for clang Dec 23, 2016
@jtran56
Copy link

jtran56 commented Dec 23, 2016

Filed as internal issue #141456.

AdamFelt pushed a commit to autodesk-forks/USD that referenced this issue Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants