WIN32 Glew and DLL fixes to CMakeLists.txt #905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, dynamic targets were disabled on Windows due to configuration
errors in the CMake install targets. In addition, glew was forced to
static linkage on windows, even when dynamic Glew libraries were linked
which would result in linker errors.
In this change, static glew libraries are detected by looking for the "s"
suffix convention on the library (though, maybe this should be handled in
the FindGlew module).
In addition, there is now a fork in the opensubdiv osd_dynamic_{cpu|gpu}
install targets to account for the Windows DLL CMake quirks.
|
/CC @meshula |
This does not cause build issues, though removing it from the public header is good hygiene.
|
Hey Jeremy! Thanks again for the PR & CLA I'm going to cherry pick this but exclude the changes related to osd_dynamic_{cpu,gpu} install and exe linking. Those are the parts of the PR which are causing the AppVeyor failures (which also repro for me locally). There's more work that we need to do to really support DLL builds, e.g. symbol exports, distinct names for the static and dynamic .libs, etc. |
|
Closing this in favor of #961 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, dynamic targets were disabled on Windows due to configuration
errors in the CMake install targets. In addition, glew was forced to
static linkage on windows, even when dynamic Glew libraries were linked
which would result in linker errors.
In this change, static glew libraries are detected by looking for the "s"
suffix convention on the library (though, maybe this should be handled in
the FindGlew module).
In addition, there is now a fork in the opensubdiv osd_dynamic_{cpu|gpu}
install targets to account for the Windows DLL CMake quirks.