Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lexical dependency is unmaintained and has soundness issues #76

Open
eric-seppanen opened this issue Feb 23, 2024 · 0 comments · May be fixed by #77
Open

lexical dependency is unmaintained and has soundness issues #76

eric-seppanen opened this issue Feb 23, 2024 · 0 comments · May be fixed by #77

Comments

@eric-seppanen
Copy link

Running cargo deny check dependencies on a project that includes wavefront_obj displays the following alert.

Please consider replacing the dependency on lexical.

ID: RUSTSEC-2023-0055
Advisory: https://rustsec.org/advisories/RUSTSEC-2023-0055
lexical contains multiple soundness issues:

  1. Bytes::read() allows creating instances of types with invalid bit patterns
  2. BytesIter::read() advances iterators out of bounds
  3. The BytesIter trait has safety invariants but is public and not marked unsafe
  4. write_float() calls MaybeUninit::assume_init() on uninitialized data, which is is not allowed by the Rust abstract machine

The crate also has some correctness issues and appears to be unmaintained.

Alternatives

For quickly parsing floating-point numbers third-party crates are no longer needed. A fast float parsing algorith by the author of lexical has been merged into libcore.

For quickly parsing integers, consider atoi and btoi crates (100% safe code). atoi_radix10 provides even faster parsing, but only with -C target-cpu=native, and at the cost of some unsafe.

For formatting integers in a #[no_std] context consider the numtoa crate.

For working with big numbers consider num-bigint and num-traits.
Solution: No safe upgrade is available!

lexical v5.2.2
└── wavefront_obj v10.0.0
jrudolph added a commit to jrudolph/wavefront_obj that referenced this issue Sep 30, 2024
@jrudolph jrudolph linked a pull request Sep 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant