Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved MEMORY to local variable in Library::init #90

Merged
merged 1 commit into from
Dec 30, 2014
Merged

Moved MEMORY to local variable in Library::init #90

merged 1 commit into from
Dec 30, 2014

Conversation

bvssvni
Copy link
Member

@bvssvni bvssvni commented Dec 30, 2014

Closes #89

bvssvni added a commit that referenced this pull request Dec 30, 2014
@bvssvni
Merge pull request #90 from bvssvni/master
6eea6c2 
Moved `MEMORY` to local variable in `Library::init`
@bvssvni bvssvni merged commit 6eea6c2 into PistonDevelopers:master Dec 30, 2014
@abonander abonander mentioned this pull request Dec 31, 2014
Open
@abonander
Copy link
Contributor

I think this is causing segfaults. The memory variable is stack-local but it looks like the library tries to dereference it later on.

@bvssvni bvssvni mentioned this pull request Jan 1, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync not implemented for some types
2 participants
@bvssvni @abonander