Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precip Accumulation is incorrect #86

Closed
augster opened this issue Feb 24, 2023 · 3 comments
Closed

Precip Accumulation is incorrect #86

augster opened this issue Feb 24, 2023 · 3 comments

Comments

@augster
Copy link

augster commented Feb 24, 2023

I'm seeing some discrepancies with the precip_accumulation_Xd sensor values when compared to Merry Sky (https://merrysky.net/forecast/48.360169781921684,-116.61274232147296/us) which I believe is using the same data...

Using the same GPS coordinate, you can see that the accumulations for sunday are drastically different; 11.4in vs 4in. Is this perhaps a unit conversion bug? 11.4cm = 4.48in?

image
image

@cloneofghosts
Copy link
Collaborator

If you display the sensor directly do you see the same value as the weather card?

I tested this earlier and I was getting 12mm for non-US units and 30mm for US units. I was using a Canadian location but that shouldn't matter in this case.

There definitely seems to be a bug in the integration as the API results are correct. I'll mention @alexander0042 so he can come and investigate.

@alexander0042
Copy link
Collaborator

I am so sorry for not getting to this one earlier- I didn't realize the extent of it at first, but it turns out I just flat out missed precipitation accumulation in the unit conversion routine, so it's always returning in SI but claiming to be whatever unit is requested. Long story short, not good!

At least it's an easy fix, so I'll push out a new version ASAP!

alexander0042 added a commit that referenced this issue Mar 8, 2023
@alexander0042
Copy link
Collaborator

And it's live! Thanks again for pointing this out, and feel free to re-open if anything else comes up!

@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants