Advance routing for ArchivePage as Child of a Page

[gyretech]

So I have a page

[PageType(Title = "Slug page", UseBlocks = false)]
[PageTypeRoute(Title = "Default", Route = "/slugpage")]
public class SlugPage : Page<SlugPage>
{        
  ......
}

So I created a page /page-slug

Now I want a page /page-slug/slug-archive So I created the following

[PageType(Title = "Slug archive page", UseBlocks = false)]
[PageTypeRoute(Title = "Default", Route = "/slugarchive")]
public class SlugArchivePage : ArchivePage<SlugArchivePage >
{
  ....
}

But what I get is: Page "/page-slug/slug-archive" cannot be found. With the following output.

info: Piranha.AspNetCore.PageMiddleware[0]
      Found page
  Route: /slugpage/slug-archive

It is obviously looking for the archive page under the page route. How do I resolve this.

[tidyui]

Have you created the page slug-archive below slug-page in the sitemap?

Regards

[gyretech]

Yes I did. slug-archive is a child of slug-page. - Keshwar

…

________________________________ From: Håkan Edling <[email protected]> Sent: Friday, July 12, 2019 4:05:11 AM To: PiranhaCMS/piranha.core Cc: Keshwar White; Author Subject: Re: [PiranhaCMS/piranha.core] Advance routing for ArchivePage as Child of a Page (#699) Have you created the page slug-archive below slug-page in the sitemap? Regards — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#699?email_source=notifications&email_token=ADAXJSEYTNH7HUJJ6JOTBMTP7A3LPA5CNFSM4ICAWAZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZZBDII#issuecomment-510792097>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADAXJSGNGYNTJBQVEF2RORTP7A3LPANCNFSM4ICAWAZA>.

[tidyui]

Ok. I can see from the info printout that it doesn’t find your archive page, it finds “slug-page” and thinks “slug-archive” is an extra route param which it passes along. As your action doesn’t accept it MVC throws 404. Have you double checked the slug of the archive so it contains the “slug-page/“ prefix?

[gyretech]

Yes I triple checked. - Keshwar

…

________________________________ From: Håkan Edling <[email protected]> Sent: Friday, July 12, 2019 7:50:19 AM To: PiranhaCMS/piranha.core Cc: Keshwar White; Author Subject: Re: [PiranhaCMS/piranha.core] Advance routing for ArchivePage as Child of a Page (#699) Ok. I can see from the info printout that it doesn’t find your archive page, it finds “slug-page” and thinks “slug-archive” is an extra route param which it passes along. As your action doesn’t accept it MVC throws 404. Have you double checked the slug of the archive so it contains the “slug-page/“ prefix? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#699?email_source=notifications&email_token=ADAXJSHZFJKKWHGRJQOMWCDP7BVXXA5CNFSM4ICAWAZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZZRDVI#issuecomment-510857685>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADAXJSAH67OGRUE6VOTECE3P7BVXXANCNFSM4ICAWAZA>.

[gyretech]

If I create a non-archive page under slug-page, that page works just fine. - Keshwar

…

________________________________ From: Håkan Edling <[email protected]> Sent: Friday, July 12, 2019 7:50:19 AM To: PiranhaCMS/piranha.core Cc: Keshwar White; Author Subject: Re: [PiranhaCMS/piranha.core] Advance routing for ArchivePage as Child of a Page (#699) Ok. I can see from the info printout that it doesn’t find your archive page, it finds “slug-page” and thinks “slug-archive” is an extra route param which it passes along. As your action doesn’t accept it MVC throws 404. Have you double checked the slug of the archive so it contains the “slug-page/“ prefix? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#699?email_source=notifications&email_token=ADAXJSHZFJKKWHGRJQOMWCDP7BVXXA5CNFSM4ICAWAZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZZRDVI#issuecomment-510857685>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADAXJSAH67OGRUE6VOTECE3P7BVXXANCNFSM4ICAWAZA>.

[gyretech]

Also I forgot to mention that I am using Razor Pages.

[gyretech]

You can actually replicate this behavior in one of your examples. Simply move “blog” under features, then edit blog so that the slug updates to “features/blog”. Then try to access “/features/blog” then you will get Page Not Found.

[tidyui]

Hi again @gyretech!

I can see from the code that the standard setup will produce the exact error you're getting. The reason for this is that the PageRouter intercepts the parent page before the ArchiveRouter gets the chance to identify the child archive. The provided middleware (in the default order) just isn't capable of finding an archive page located below a regular page. To fix this in your project. let's take a look at what the extension method AddPiranha does:

public static IApplicationBuilder UsePiranha(this IApplicationBuilder builder)
{
    return builder
        .UseMiddleware<Piranha.AspNetCore.ApplicationMiddleware>()
        .UseMiddleware<Piranha.AspNetCore.AliasMiddleware>()
        .UseMiddleware<Piranha.AspNetCore.PageMiddleware>()
        .UseMiddleware<Piranha.AspNetCore.PostMiddleware>()
        .UseMiddleware<Piranha.AspNetCore.ArchiveMiddleware>()
        .UseMiddleware<Piranha.AspNetCore.StartPageMiddleware>()
        .UseMiddleware<Piranha.AspNetCore.SitemapMiddleware>();
}

The problem here is that the ArchiveMiddleware is positioned after the PageMiddleware in the pipeline. Instead of calling this method, call the appropriate extension methods for adding all of the desired middleware in the order your need, in your case ArchiveMiddleware before PageMiddleware. To clarify, this will disable the possibility to add a regular page below an archive page.

Best regards

Håkan

[tidyui]

Btw @gyretech did you have a PR for this, because you solved it on your end right?

[gyretech]

I will submit a PR for this today. - Keshwar

…

________________________________ From: Håkan Edling <[email protected]> Sent: Monday, July 29, 2019 5:18:32 AM To: PiranhaCMS/piranha.core <[email protected]> Cc: Keshwar White <[email protected]>; Mention <[email protected]> Subject: Re: [PiranhaCMS/piranha.core] Advance routing for ArchivePage as Child of a Page (#699) Btw @gyretech<https://github.com/gyretech> did you have a PR for this, because you solved it on your end right? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#699?email_source=notifications&email_token=ADAXJSCJUNFGZDQDBCBT35LQB2YWRA5CNFSM4ICAWAZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ADUYY#issuecomment-515914339>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADAXJSFHPN7CHAVVDQPWDPLQB2YWRANCNFSM4ICAWAZA>.

[tidyui]

Moved to 8.0 as we will implement a completely new routing middleware for this major version