Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Manager Login - ReturnUrl in LoginModel is allways null #579

Closed
fdhighhead opened this issue Apr 9, 2019 · 5 comments
Closed

Using Manager Login - ReturnUrl in LoginModel is allways null #579

fdhighhead opened this issue Apr 9, 2019 · 5 comments

Comments

@fdhighhead
Copy link

fdhighhead commented Apr 9, 2019

Hi guys,

its my first issue so excuse me for any mistakes.

Going directly to e.g. "baseUrl/manager/users" the login form shows up.
Adress in Browser is "baseUrl/manager/login?ReturnUrl=%2Fmanager%2Fusers".

Debugging the login process shows that the UserName and Password is passed correctly but the ReturnUrl is allways null. This szenario is in all common Browsers (Edge, Ff, Chrome etc.) the same.

If i use e.g. Postman to test the Post-Request by using either
"baseurl/manager/login?ReturnUrl=%2Fmanager%2Fusers&UserName=admin&Password=password"
or
"baseUrl/manager/login?ReturnUrl=%2Fmanager%2Fusers" (UserName and Password as form-data)
the login process runs as expected...

I used the latest piranha.core master repo to debug the Piranha.Manager component.

Thanks for your good work!
Greetings and have a nice week.

@pkreemer
Copy link

pkreemer commented Apr 9, 2019 via email

@tidyui
Copy link
Member

tidyui commented Apr 10, 2019

It looks like the view isn’t actually forwarding the LoginUrl to the login action

@fdhighhead
Copy link
Author

Are you using https? I think I saw the same symptoms when running just http.

Yes i tried. Same issue.

It looks like the view isn’t actually forwarding the LoginUrl to the login action

I just tried to forward returnUrl as a hidden field - that worked.

If i get it right, the DefaultIdentity given by Microsoft uses in the Login view the whole LoginModel, not only the string (returnUrl). So i guess there is something wrong?

thank you for your quick answer!

@tidyui
Copy link
Member

tidyui commented Apr 14, 2019

We'll add the ReturnUrl to the login view for 6.1

@tidyui tidyui added this to the Version 6.1 milestone Apr 14, 2019
@tidyui tidyui closed this as completed in ffc3997 Apr 20, 2019
@tidyui tidyui self-assigned this Apr 25, 2019
@nahojd
Copy link

nahojd commented Feb 6, 2020

This seems to have disappeared again in the new manager interface from version 7.0, because ReturnUrl does not work at all. And in Login.cshtml there is no ReturnUrl, nor in Login.cshtml.cs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants