-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Components] klipfolio #13229 #14693
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (3)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThis pull request introduces several new modules for managing data sources within the Klipfolio platform, including functionalities for creating, updating, and deleting data sources. It also adds a new constants module and updates the application integration file. Additionally, a Changes
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
🧹 Outside diff range and nitpick comments (10)
components/klipfolio/actions/delete-datasource/delete-datasource.mjs (3)
3-8
: LGTM with a minor suggestion for the description!The action metadata is well-structured. Consider enhancing the description to mention any limitations or important considerations when deleting a datasource.
- description: "Delete the data source associated with a specific data source ID. [See the documentation](https://apidocs.klipfolio.com/reference/data-sources#delete-datasourcesid)", + description: "Delete the data source associated with a specific data source ID. Note: This action permanently removes the datasource and cannot be undone. [See the documentation](https://apidocs.klipfolio.com/reference/data-sources#delete-datasourcesid)",
9-17
: Fix missing trailing commas in props definition.Add trailing commas for better git diffs and consistency with the codebase style.
propDefinition: [ app, - "datasourceId" + "datasourceId", - ] + ], },🧰 Tools
🪛 eslint
[error] 14-15: Missing trailing comma.
(comma-dangle)
[error] 15-16: Missing trailing comma.
(comma-dangle)
19-26
: Consider adding error handling and enhancing the success message.While the implementation is functional, it could benefit from proper error handling and a more informative success message.
async run({ $ }) { + try { const response = await this.app.deleteDatasource({ $, datasourceId: this.datasourceId, }); - $.export("$summary", `Successfully deleted datasource with ID: ${this.datasourceId}`); + $.export("$summary", `Successfully deleted datasource ${this.datasourceId}. Status: ${response.status}`); return response; + } catch (error) { + throw new Error(`Failed to delete datasource: ${error.message}`); + } },components/klipfolio/actions/update-datasource/update-datasource.mjs (2)
1-8
: LGTM! Consider starting with version 1.0.0The module definition and metadata look good, with clear description and documentation link. However, since this appears to be the initial release of a production-ready component, consider starting with version 1.0.0 instead of 0.0.1.
- version: "0.0.1", + version: "1.0.0",
11-34
: Fix missing trailing commas for consistencyAdd trailing commas to maintain consistent style and make future additions easier.
propDefinition: [ app, - "datasourceId" + "datasourceId", ] }, name: { propDefinition: [ app, - "name" + "name", ] }, description: { propDefinition: [ app, - "description" + "description", ] }, refreshInterval: { propDefinition: [ app, - "refreshInterval" + "refreshInterval", ] },🧰 Tools
🪛 eslint
[error] 14-15: Missing trailing comma.
(comma-dangle)
[error] 15-16: Missing trailing comma.
(comma-dangle)
[error] 20-21: Missing trailing comma.
(comma-dangle)
[error] 21-22: Missing trailing comma.
(comma-dangle)
[error] 26-27: Missing trailing comma.
(comma-dangle)
[error] 27-28: Missing trailing comma.
(comma-dangle)
[error] 32-33: Missing trailing comma.
(comma-dangle)
[error] 33-34: Missing trailing comma.
(comma-dangle)
components/klipfolio/actions/create-datasource/create-datasource.mjs (1)
9-53
: Add trailing commas for better git diffs.Adding trailing commas helps prevent merge conflicts and makes git diffs cleaner when new properties are added.
Apply this style fix:
propDefinition: [ app, - "name" + "name", ](Apply similar fixes to all prop definitions)
🧰 Tools
🪛 eslint
[error] 14-15: Missing trailing comma.
(comma-dangle)
[error] 15-16: Missing trailing comma.
(comma-dangle)
[error] 20-21: Missing trailing comma.
(comma-dangle)
[error] 21-22: Missing trailing comma.
(comma-dangle)
[error] 26-27: Missing trailing comma.
(comma-dangle)
[error] 27-28: Missing trailing comma.
(comma-dangle)
[error] 32-33: Missing trailing comma.
(comma-dangle)
[error] 33-34: Missing trailing comma.
(comma-dangle)
[error] 38-39: Missing trailing comma.
(comma-dangle)
[error] 39-40: Missing trailing comma.
(comma-dangle)
[error] 44-45: Missing trailing comma.
(comma-dangle)
[error] 45-46: Missing trailing comma.
(comma-dangle)
[error] 50-51: Missing trailing comma.
(comma-dangle)
[error] 51-52: Missing trailing comma.
(comma-dangle)
components/klipfolio/klipfolio.app.mjs (4)
18-22
: Add predefined format options for better validation.Consider adding predefined options for the format property to prevent invalid formats and improve user experience.
format: { type: "string", label: "Format", description: "Format of the Datasource, i.e.: `xml`", + options: ["xml", "json", "csv", "excel"], },
40-44
: Add predefined HTTP methods for better validation.Consider adding predefined options for the HTTP methods to prevent invalid methods.
method: { type: "string", label: "Method", description: "Method for the endpoint, i.e.: `GET`", + options: ["GET", "POST", "PUT", "DELETE", "PATCH"], },
60-62
: Consider making API version configurable.The API version is hardcoded in the base URL. Consider making it configurable for better maintainability.
+const API_VERSION = "1.0"; + _baseUrl() { - return `https://app.klipfolio.com/api/1.0`; + return `https://app.klipfolio.com/api/${API_VERSION}`; }🧰 Tools
🪛 eslint
[error] 61-61: Strings must use doublequote.
(quotes)
1-107
: Fix code formatting issues.Several formatting issues were detected by eslint:
- Add line breaks in object destructuring
- Add trailing commas
- Use consistent string quotes
Consider running the project's linter to automatically fix these issues.
🧰 Tools
🪛 eslint
[error] 52-52: Expected a line break after this opening brace.
(object-curly-newline)
[error] 52-52: Expected a line break before this closing brace.
(object-curly-newline)
[error] 54-55: Missing trailing comma.
(comma-dangle)
[error] 56-57: Missing trailing comma.
(comma-dangle)
[error] 61-61: Strings must use doublequote.
(quotes)
[error] 86-86: Expected a line break after this opening brace.
(object-curly-newline)
[error] 86-86: Expected a line break before this closing brace.
(object-curly-newline)
[error] 93-93: Expected a line break after this opening brace.
(object-curly-newline)
[error] 93-93: Expected a line break before this closing brace.
(object-curly-newline)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (8)
components/klipfolio/.gitignore
(0 hunks)components/klipfolio/actions/create-datasource/create-datasource.mjs
(1 hunks)components/klipfolio/actions/delete-datasource/delete-datasource.mjs
(1 hunks)components/klipfolio/actions/update-datasource/update-datasource.mjs
(1 hunks)components/klipfolio/app/klipfolio.app.ts
(0 hunks)components/klipfolio/common/constants.mjs
(1 hunks)components/klipfolio/klipfolio.app.mjs
(1 hunks)components/klipfolio/package.json
(1 hunks)
💤 Files with no reviewable changes (2)
- components/klipfolio/.gitignore
- components/klipfolio/app/klipfolio.app.ts
🧰 Additional context used
🪛 eslint
components/klipfolio/actions/create-datasource/create-datasource.mjs
[error] 14-15: Missing trailing comma.
(comma-dangle)
[error] 15-16: Missing trailing comma.
(comma-dangle)
[error] 20-21: Missing trailing comma.
(comma-dangle)
[error] 21-22: Missing trailing comma.
(comma-dangle)
[error] 26-27: Missing trailing comma.
(comma-dangle)
[error] 27-28: Missing trailing comma.
(comma-dangle)
[error] 32-33: Missing trailing comma.
(comma-dangle)
[error] 33-34: Missing trailing comma.
(comma-dangle)
[error] 38-39: Missing trailing comma.
(comma-dangle)
[error] 39-40: Missing trailing comma.
(comma-dangle)
[error] 44-45: Missing trailing comma.
(comma-dangle)
[error] 45-46: Missing trailing comma.
(comma-dangle)
[error] 50-51: Missing trailing comma.
(comma-dangle)
[error] 51-52: Missing trailing comma.
(comma-dangle)
[error] 67-68: Missing trailing comma.
(comma-dangle)
components/klipfolio/actions/delete-datasource/delete-datasource.mjs
[error] 14-15: Missing trailing comma.
(comma-dangle)
[error] 15-16: Missing trailing comma.
(comma-dangle)
components/klipfolio/actions/update-datasource/update-datasource.mjs
[error] 14-15: Missing trailing comma.
(comma-dangle)
[error] 15-16: Missing trailing comma.
(comma-dangle)
[error] 20-21: Missing trailing comma.
(comma-dangle)
[error] 21-22: Missing trailing comma.
(comma-dangle)
[error] 26-27: Missing trailing comma.
(comma-dangle)
[error] 27-28: Missing trailing comma.
(comma-dangle)
[error] 32-33: Missing trailing comma.
(comma-dangle)
[error] 33-34: Missing trailing comma.
(comma-dangle)
components/klipfolio/common/constants.mjs
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-3: There should be a linebreak after this element.
(array-element-newline)
[error] 3-3: Strings must use doublequote.
(quotes)
[error] 3-4: Missing trailing comma.
(comma-dangle)
[error] 6-6: Strings must use doublequote.
(quotes)
[error] 6-6: There should be a linebreak after this element.
(array-element-newline)
[error] 6-6: Strings must use doublequote.
(quotes)
[error] 6-6: There should be a linebreak after this element.
(array-element-newline)
[error] 6-6: Strings must use doublequote.
(quotes)
[error] 6-6: There should be a linebreak after this element.
(array-element-newline)
[error] 6-6: Strings must use doublequote.
(quotes)
[error] 6-6: There should be a linebreak after this element.
(array-element-newline)
[error] 6-6: Strings must use doublequote.
(quotes)
[error] 6-6: There should be a linebreak after this element.
(array-element-newline)
[error] 6-6: Strings must use doublequote.
(quotes)
[error] 6-6: There should be a linebreak after this element.
(array-element-newline)
[error] 6-6: Strings must use doublequote.
(quotes)
[error] 6-6: There should be a linebreak after this element.
(array-element-newline)
[error] 6-6: Strings must use doublequote.
(quotes)
[error] 6-6: There should be a linebreak after this element.
(array-element-newline)
[error] 6-6: Strings must use doublequote.
(quotes)
[error] 6-6: There should be a linebreak after this element.
(array-element-newline)
[error] 6-6: Strings must use doublequote.
(quotes)
[error] 6-6: There should be a linebreak after this element.
(array-element-newline)
[error] 6-6: Strings must use doublequote.
(quotes)
[error] 6-7: Missing trailing comma.
(comma-dangle)
[error] 7-8: Missing trailing comma.
(comma-dangle)
[error] 8-8: Newline required at end of file but not found.
(eol-last)
[error] 8-8: Missing semicolon.
(semi)
components/klipfolio/klipfolio.app.mjs
[error] 52-52: Expected a line break after this opening brace.
(object-curly-newline)
[error] 52-52: Expected a line break before this closing brace.
(object-curly-newline)
[error] 54-55: Missing trailing comma.
(comma-dangle)
[error] 56-57: Missing trailing comma.
(comma-dangle)
[error] 61-61: Strings must use doublequote.
(quotes)
[error] 86-86: Expected a line break after this opening brace.
(object-curly-newline)
[error] 86-86: Expected a line break before this closing brace.
(object-curly-newline)
[error] 93-93: Expected a line break after this opening brace.
(object-curly-newline)
[error] 93-93: Expected a line break before this closing brace.
(object-curly-newline)
🔇 Additional comments (11)
components/klipfolio/package.json (3)
10-12
: LGTM! Correct files configuration for distribution
The files array correctly specifies only the dist
directory for package distribution, which is the appropriate approach for published npm packages.
3-3
: Verify version bump alignment with changes
The version bump from 0.0.2 to 0.1.0 suggests new features. Given the addition of new data source management modules, please confirm this is the appropriate semantic version increment.
✅ Verification successful
Version bump from 0.0.2 to 0.1.0 is appropriate
The minor version bump (0.0.2 to 0.1.0) is justified based on the evidence:
- Added three new feature-rich actions for datasource management:
- create-datasource (new functionality)
- delete-datasource (new functionality)
- update-datasource (new functionality)
- No breaking changes were detected in existing files
- Changes follow semantic versioning principles where new features warrant a minor version increment
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check the extent of changes to determine if minor version bump is appropriate
# Look for new feature files
echo "New feature files:"
fd . components/klipfolio/actions -t f -e mjs
# Check for breaking changes in existing files
echo -e "\nPotential breaking changes in existing files:"
rg -l "BREAKING CHANGE" components/klipfolio/
Length of output: 456
Script:
#!/bin/bash
# Let's analyze the changes more comprehensively
# Check git diff of package.json to see all changes
echo "Package changes:"
git diff origin/master -- components/klipfolio/package.json || true
# List all files in the component to understand the scope
echo -e "\nComponent structure:"
fd . components/klipfolio -t f
# Check for changes in existing action files
echo -e "\nExisting actions diff:"
git diff origin/master -- 'components/klipfolio/actions/**/*.mjs' || true
Length of output: 5917
18-20
: Verify platform dependency version and type
The addition of @pipedream/platform
as a direct dependency looks correct, but please verify:
- If version ^3.0.3 is the latest stable version
- Whether this should be a peerDependency instead of a direct dependency
✅ Verification successful
Based on the search results, I can now provide a final response since I have enough information to verify the platform dependency version and type:
Platform dependency version is up-to-date and correctly specified
The version ^3.0.3
is appropriate as:
- It matches the latest major version (3.x.x) used across many recently updated components
- The caret range allows for compatible minor and patch updates
- It's being used as a direct dependency which is the correct type, as evidenced by widespread similar usage across hundreds of other components
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check latest version of @pipedream/platform and its usage pattern
# Check if other components use this as a peer dependency
echo "Dependency pattern in other components:"
fd package.json components/ -x grep -l "@pipedream/platform"
# Look for version declarations
echo -e "\nVersion patterns:"
rg '"@pipedream/platform":\s*"[^"]*"' components/
Length of output: 140370
components/klipfolio/actions/delete-datasource/delete-datasource.mjs (2)
1-1
: LGTM!
The import statement correctly references the Klipfolio app module.
20-23
: Verify the app module implementation.
Let's ensure that the deleteDatasource
method is properly implemented in the app module.
✅ Verification successful
Implementation of deleteDatasource
method is properly integrated
The verification shows that the deleteDatasource
method is correctly implemented in klipfolio.app.mjs
. It:
- Accepts the required parameters (
datasourceId
and additional args) - Makes an HTTP DELETE request to the appropriate endpoint
/datasources/${datasourceId}
- Uses the app's
_makeRequest
method for consistent API communication
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for the deleteDatasource method implementation in the app module
ast-grep --pattern 'deleteDatasource({ $, datasourceId }) {
$$$
}'
# Also check for any existing usage patterns
rg -A 5 'deleteDatasource'
Length of output: 1164
components/klipfolio/actions/update-datasource/update-datasource.mjs (2)
9-35
: LGTM! Props are well-structured
The props are properly defined using propDefinitions from the app, providing a clean interface for the action.
🧰 Tools
🪛 eslint
[error] 14-15: Missing trailing comma.
(comma-dangle)
[error] 15-16: Missing trailing comma.
(comma-dangle)
[error] 20-21: Missing trailing comma.
(comma-dangle)
[error] 21-22: Missing trailing comma.
(comma-dangle)
[error] 26-27: Missing trailing comma.
(comma-dangle)
[error] 27-28: Missing trailing comma.
(comma-dangle)
[error] 32-33: Missing trailing comma.
(comma-dangle)
[error] 33-34: Missing trailing comma.
(comma-dangle)
38-46
: Verify updateDatasource implementation
Let's verify the implementation of the updateDatasource method in the app file.
✅ Verification successful
Implementation of updateDatasource is correctly integrated
The updateDatasource method is properly implemented in klipfolio.app.mjs
and correctly used in the action component. The app method:
- Accepts the required parameters (datasourceId and additional args)
- Makes a PUT request to the correct endpoint
/datasources/${datasourceId}
- Properly forwards all additional arguments to the request
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for updateDatasource implementation
ast-grep --pattern 'updateDatasource({ $, datasourceId, data }) {
$$$
}'
Length of output: 76
Script:
#!/bin/bash
# Let's try a broader search for updateDatasource method using ripgrep
rg -l "updateDatasource" --type js --type mjs
# Then let's look at the implementation
rg "updateDatasource" --type js --type mjs -A 5
Length of output: 149
Script:
#!/bin/bash
# Search for files containing updateDatasource without type filtering
rg -l "updateDatasource"
# Then look at the implementation
rg "updateDatasource" -A 5
Length of output: 1182
components/klipfolio/actions/create-datasource/create-datasource.mjs (3)
1-8
: LGTM! Well-structured component metadata.
The metadata is well-defined with appropriate versioning, documentation link, and follows naming conventions.
56-69
: Verify createDatasource implementation.
Let's check the implementation of createDatasource method in the app module to ensure proper API integration.
✅ Verification successful
Implementation verified and properly handles data
The createDatasource
method in klipfolio.app.mjs
is correctly implemented. It:
- Makes a POST request to
/datasources
endpoint - Properly forwards all arguments including the data object
- Uses the standard
_makeRequest
pattern consistent with other API methods - Correctly handles the async/await pattern
The implementation aligns well with the usage in create-datasource.mjs
and follows RESTful API practices.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check createDatasource implementation
# Expected: Should find the method implementation with proper API call
ast-grep --pattern 'async createDatasource({ $, data }) {
$$$
}'
Length of output: 68
Script:
#!/bin/bash
# Let's try a broader search for the createDatasource method and API integration
# First, let's find the app module file
fd -t f "app.mjs|app.js" components/klipfolio
# Then search for createDatasource implementation with different pattern
ast-grep --pattern 'createDatasource($$$) {
$$$
}'
# Backup search using ripgrep
rg -l "createDatasource" components/klipfolio
Length of output: 295
Script:
#!/bin/bash
# Let's examine the implementation in klipfolio.app.mjs
cat components/klipfolio/klipfolio.app.mjs | grep -A 20 "createDatasource"
# Also let's check if there are any HTTP endpoints related to datasource creation
rg -A 5 "datasource" components/klipfolio/klipfolio.app.mjs
Length of output: 1648
🧰 Tools
🪛 eslint
[error] 67-68: Missing trailing comma.
(comma-dangle)
9-53
: Verify prop definitions in app module.
Let's verify that all prop definitions are properly implemented in the app module with appropriate validations and options.
🧰 Tools
🪛 eslint
[error] 14-15: Missing trailing comma.
(comma-dangle)
[error] 15-16: Missing trailing comma.
(comma-dangle)
[error] 20-21: Missing trailing comma.
(comma-dangle)
[error] 21-22: Missing trailing comma.
(comma-dangle)
[error] 26-27: Missing trailing comma.
(comma-dangle)
[error] 27-28: Missing trailing comma.
(comma-dangle)
[error] 32-33: Missing trailing comma.
(comma-dangle)
[error] 33-34: Missing trailing comma.
(comma-dangle)
[error] 38-39: Missing trailing comma.
(comma-dangle)
[error] 39-40: Missing trailing comma.
(comma-dangle)
[error] 44-45: Missing trailing comma.
(comma-dangle)
[error] 45-46: Missing trailing comma.
(comma-dangle)
[error] 50-51: Missing trailing comma.
(comma-dangle)
[error] 51-52: Missing trailing comma.
(comma-dangle)
components/klipfolio/klipfolio.app.mjs (1)
1-6
: LGTM! Clean imports and app configuration.
The imports and basic app configuration are well-structured and follow best practices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the changes to rentman
and the changes to the package-lock.json
in the pipedream root directory from this PR?
data: { | ||
name: this.name, | ||
description: this.description, | ||
refreshInterval: this.refreshInterval, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't refreshInterval
be parsed here like in create-datasource?
refreshInterval: this.refreshInterval, | |
refreshInterval: parseInt(this.refreshInterval, 10), | |
@@ -1,16 +1,21 @@ | |||
{ | |||
"name": "@pipedream/klipfolio", | |||
"version": "0.0.2", | |||
"version": "0.1.0", | |||
"description": "Pipedream Klipfolio Components", | |||
"main": "dist/app/klipfolio.app.mjs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"main": "dist/app/klipfolio.app.mjs", | |
"main": "klipfolio.app.mjs", |
"files": [ | ||
"dist" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"files": [ | |
"dist" | |
], |
Also, make sure to resolve the merge conflicts with |
WHY
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
.gitignore
file, allowing tracking of previously ignored files.Chores