Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): missing user prop definitions #12808

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

joscha
Copy link
Contributor

@joscha joscha commented Jul 11, 2024

See https://pipedream.com/docs/components/api#user-input-props

WHY

missing properties in type definitions.

Summary by CodeRabbit

  • New Features
    • Introduced disabled and hidden properties for users, allowing user properties to be marked as disabled or hidden.

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Jul 11, 2024 2:27pm

Copy link

vercel bot commented Jul 11, 2024

@joscha is attempting to deploy a commit to the Pipedreamers Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Jul 11, 2024

Walkthrough

The primary change involves adding two new properties, disabled and hidden, to the UserProp interface within the types/src/index.ts file. This enhancement aims to provide additional control and flexibility over user properties within the application.

Changes

File Change Summary
types/src/index.ts Added disabled and hidden properties to the UserProp interface

Poem

In code's vast field, new seeds are sown,
disabled and hidden, now clearly shown.
User props enhanced, with care and might,
Bringing new power, from day to night. 🌙✨
In every line, a rabbit's cheer,
For code that shines, both bright and clear.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dylburger dylburger added the User submitted Submitted by a user label Jul 11, 2024
@dylburger dylburger added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Jul 11, 2024
@joscha joscha changed the title fix: missing user prop definition fix(types): missing user prop definitions Jul 11, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e11f8cf and 7d5743f.

Files selected for processing (1)
  • types/src/index.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • types/src/index.ts

Copy link
Collaborator

@michelle0927 michelle0927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/fix-types-missing-user-prop-definitions-12808-0561c80fd40c4695a785b63ff1ff4f41

@joscha
Copy link
Contributor Author

joscha commented Jul 11, 2024

can we do a publish of the new types after this @michelle0927, please? I noticed the last changes from #11945 also haven't been published, yet.

@michelle0927 michelle0927 merged commit 7b154b3 into PipedreamHQ:master Jul 11, 2024
6 of 7 checks passed
@joscha joscha deleted the patch-4 branch July 11, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged For maintainers: This issue has been triaged by a Pipedream employee User submitted Submitted by a user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants