Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): dedupe unique and greatest strategy needs id #11945

Merged
merged 4 commits into from
May 16, 2024
Merged

fix(types): dedupe unique and greatest strategy needs id #11945

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea09407
fix(types): dedupe unique and greatest strategy needs id
joscha May 14, 2024
70e85af
chore: workaround for changed files check due to forcce push
joscha May 14, 2024
2b9e1c9
chore: fix lints
joscha May 14, 2024
ae24da7
chore: fix lints
joscha May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/pull-request-checks.yaml
View file
Open in desktop
Copy link
Contributor Author

@joscha joscha May 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for #11945 (comment) a possibly better way would be to use a fork of the original unmaintained action in https://github.com/Ana06/get-changed-files - it's a drop in replacement with a fix for the issue and a few other improvements. Let me know if you prefer the fork.

Copy link
Contributor Author

@joscha joscha May 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened an adjacent pull request in #11949
will rebase this PR on top of it, if it gets merged before and remove the continue-on-error flags.

Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
- uses: jitterbit/get-changed-files@v1
id: changed_files
name: Get changed files
continue-on-error: true
- id: md_changed_files
name: Spellcheck Markdown files
run: |-
Expand Down Expand Up @@ -93,13 +94,15 @@ jobs:
uses: jitterbit/get-changed-files@v1
with:
format: 'space-delimited'
continue-on-error: true
- name: Lint changed files
run: npx eslint --quiet ${{ steps.changed_files_space.outputs.added_modified }} ${{ steps.changed_files_space.outputs.renamed }}
- name: Get Changed Files (comma-separated)
id: changed_files
uses: jitterbit/get-changed-files@v1
with:
format: 'csv'
continue-on-error: true
# NOTE: These steps are kept in this workflow to avoid re-rerunning the rest of the lint job
# in the Components Checks workflow
- name: Check component keys
Expand Down
Loading