Skip to content

Commit

Permalink
fix macos v8 build (envoyproxy#13572)
Browse files Browse the repository at this point in the history
Signed-off-by: Rama Chavali <[email protected]>
  • Loading branch information
ramaraochavali authored and PiotrSikora committed Nov 19, 2020
1 parent 6782c85 commit 4ddf22e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions bazel/external/wee8.BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ cc_library(
"wee8/include/v8-version.h",
"wee8/third_party/wasm-api/wasm.hh",
],
copts = [
"-Wno-range-loop-analysis",
],
defines = ["ENVOY_WASM_V8"],
includes = [
"wee8/include",
Expand Down
2 changes: 1 addition & 1 deletion bazel/external/wee8.genrule_cmd
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ pushd $$ROOT/wee8
rm -rf out/wee8

# Export compiler configuration.
export CXXFLAGS="$${CXXFLAGS-} -Wno-sign-compare -Wno-deprecated-copy -Wno-unknown-warning-option"
export CXXFLAGS="$${CXXFLAGS-} -Wno-sign-compare -Wno-deprecated-copy -Wno-unknown-warning-option -Wno-range-loop-analysis"
if [[ ( `uname` == "Darwin" && $${CXX-} == "" ) || $${CXX-} == *"clang"* ]]; then
export IS_CLANG=true
export CC=$${CC:-clang}
Expand Down

0 comments on commit 4ddf22e

Please sign in to comment.