Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated effect according to API changes #20

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

Lehonti
Copy link
Contributor

@Lehonti Lehonti commented Oct 3, 2024

@cameronwhite
Copy link
Member

Hmm, it seems like the CI builds didn't run, maybe because there hasn't been a commit in this repo for a while?

This didn't compile for me though - I think you'll need to update the git submodule for Pinta to build against the latest commit

NightVisionEffect.cs(52,30): error CS0508: 'NightVisionEffect.LaunchConfiguration()': return type must be 'void' to match overridden member 'BaseEffect.LaunchConfiguration()' [/Users/cameron/code/NightVisionEffect/NightVisionAddin/NightVisionAddin.csproj]

@Lehonti
Copy link
Contributor Author

Lehonti commented Oct 4, 2024

I just updated the submodule by running the following:

git clone --recurse-submodules https://github.com/Lehonti/NightVisionEffect_fork.git
cd .\NightVisionEffect_fork\
git submodule update --remote
git add .
git commit -m "update Pinta submodule"
git push origin

However, the build fails.

@Lehonti
Copy link
Contributor Author

Lehonti commented Oct 4, 2024

I see that the problem is related to a constructor, so I will check that.

@Lehonti
Copy link
Contributor Author

Lehonti commented Oct 4, 2024

I added the missing argument to the effect that is created inside Render. I hope this fixes it

@cameronwhite
Copy link
Member

Yep looks good now - thanks!

@cameronwhite cameronwhite merged commit 397f245 into PintaProject:master Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants