Skip to content

Commit

Permalink
Revert "fix(charts/prow): insert the default env (#359)" (#360)
Browse files Browse the repository at this point in the history
This reverts commit aac685f.
  • Loading branch information
wuhuizuo authored Dec 20, 2022
1 parent aac685f commit 5c81ef4
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 13 deletions.
3 changes: 1 addition & 2 deletions apps/staging/prow/release/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spec:
chart:
spec:
chart: prow
version: 0.6.3
version: 0.6.2
sourceRef:
kind: HelmRepository
name: ee-ops
Expand Down Expand Up @@ -79,7 +79,6 @@ spec:
- --github-app-id=$(GITHUB_APP_ID)
- --github-app-private-key-path=/etc/github/cert
- --github-endpoint=http://ghproxy
- --github-graphql-endpoint=http://ghproxy/graphql
volumes:
- name: external-plugins-config
configMap:
Expand Down
2 changes: 1 addition & 1 deletion charts/prow/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ type: application
# time you make changes to the chart and its templates,
# including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: "0.6.3"
version: "0.6.2"

# This is the version number of the application being deployed.
# This version number should be incremented each time you make changes to the
Expand Down
11 changes: 2 additions & 9 deletions charts/prow/templates/third-plugins/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,17 +63,10 @@ spec:
- --github-endpoint=http://{{ include "prow.fullname.ghproxy" $root }}
- --github-graphql-endpoint=http://{{ include "prow.fullname.ghproxy" $root }}/graphql
{{- end }}
{{- if $val.env }}
env:
{{- if not (contains "GITHUB_APP_ID" (quote $val.env)) }}
- name: GITHUB_APP_ID
valueFrom:
secretKeyRef:
name: {{ include "prow.fullname" $root }}-github-token
key: appid
{{- end }}
{{- if $val.env }}
{{- toYaml $val.env | nindent 12 }}
{{- end }}
{{- end }}
ports:
- name: http
containerPort: {{ $val.ports.http | default 80 }}
Expand Down
2 changes: 1 addition & 1 deletion infrastructure/staging/monitoring/operator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
name: prometheus-operator
namespace: flux-system
spec:
interval: 24h
interval: 10m0s
path: ./manifests/setup
prune: true
sourceRef:
Expand Down

0 comments on commit 5c81ef4

Please sign in to comment.