feat(tiflow): upload tiflow ut codecoverage if test passed

[purelind]

• upload tiflow ut codecoverage if test passed
• upload code coveage in master and lts branch's pull requests

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.
Summary:

The pull request adds the feature to upload tiflow ut code coverage if tests pass and upload code coverage in master and lts branch. The changes involve updating environment variables and adding a script to upload code coverage.

Potential problems:

1. The pull request only adds the feature to upload code coverage to the tiflow pipeline. It might be necessary to add this feature to other pipelines as well.
2. The TICDC_CODECOV_TOKEN and TICDC_COVERALLS_TOKEN environment variables are not used anymore. If these variables are used elsewhere, it might cause issues in other parts of the application.

Fixing suggestions:

1. If uploading code coverage is needed in other pipelines, it might be necessary to create a common function to upload code coverage and use it across all pipelines.
2. If the TICDC_CODECOV_TOKEN and TICDC_COVERALLS_TOKEN environment variables are used elsewhere, it might be necessary to update these variables to use the CODECOV_TOKEN.

Overall, the changes seem straightforward and do not introduce any major issues.

[purelind]

replay tests

• master https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftiflow%2Fghpr_verify/detail/ghpr_verify/185/pipeline/158
• release-7.5 https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftiflow%2Frelease-7.5%2Fghpr_verify/detail/ghpr_verify/16/pipeline
• release-7.1 https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftiflow%2Frelease-7.1%2Fghpr_verify/detail/ghpr_verify/20/pipeline
• release-6.5 https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftiflow%2Frelease-6.5%2Fghpr_verify/detail/ghpr_verify/49/pipeline
• release-6.1 https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftiflow%2Frelease-6.1%2Fghpr_verify/detail/ghpr_verify/3/pipeline

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.
Pull Request Review

The pull request adds a new feature to upload tiflow ut code coverage if the test passed. The key changes are adding the CODECOV_TOKEN environment variable and a new script to upload the coverage results.

However, there are some potential problems that need to be addressed:

• The description of the pull request is not descriptive enough. It would be helpful to provide more context about the feature being added.
• The script to upload the code coverage results seems to be repeated in every branch. It may be better to create a separate script and include it in each branch rather than repeating the same code.
• It is not clear what happens if the tests fail. The script only runs if the tests pass. It would be helpful to include an error message or notification if the tests fail.

Fixing Suggestions:

• Provide a more descriptive pull request description that details what the feature is and how it works.
• Create a separate script to upload the code coverage results and include it in each branch.
• Add an error message or notification if the tests fail.

[purelind]

we need to remove the upload step in the tiflow makefile. pingcap/tiflow#10446

[wuhuizuo]

Ref:

• How to make the testing observable by coverage data #2171

Let's migrate to use flags to separate test types. components will be identified auto by file path defined in repo's codecov.yaml file.

[purelind]

Does this PR pingcap/tiflow#9252 need to be cherry-picked to other LTS branches?

[wuhuizuo]

• upload tiflow ut codecoverage if test passed
• upload code coveage in master and lts branch

But it will just upload coverage for pull request, we also need another postsubmit job to upload coverage to base branch

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.
Pull Request Review

Key Changes:

• The PR is adding code to upload tiflow ut codecoverage if the test has passed.
• It is uploading code coverage in master and lts branch's pull requests.

Potential Problems:

• It is not clear what prow.uploadCoverageToCodecov method does. It is not defined in the given code, so it may throw an error.
• The environment variable names have been changed from TICDC_CODECOV_TOKEN and TICDC_COVERALLS_TOKEN to CODECOV_TOKEN. This may cause a problem if these variables are being used somewhere else in the code.
• It is not clear if the code coverage is being uploaded to the correct location or not.

Fixing Suggestions:

• Define the method prow.uploadCoverageToCodecov if it is not already defined.
• Use a different name for the environment variables that are not already being used in the code.
• Add comments to the code to make it clear what prow.uploadCoverageToCodecov method does and what parameters it takes.
• Verify if the code coverage is being uploaded to the correct location or not.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pipelines/OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-01-11 09:24:48.819324162 +0000 UTC m=+521678.403577869: ☑️ agreed by wuhuizuo.