Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pipelines/pingcap/tidb): fix coverage data path and refactor unit job #2288

Merged
merged 1 commit into from
Jul 19, 2023
Merged

fix(pipelines/pingcap/tidb): fix coverage data path and refactor unit job #2288

merged 1 commit into from
Jul 19, 2023

Conversation

wuhuizuo
Copy link
Collaborator

@ti-chi-bot ti-chi-bot bot requested a review from jayl1e July 19, 2023 09:30
@ti-chi-bot ti-chi-bot bot requested a review from purelind July 19, 2023 09:30
@ti-chi-bot ti-chi-bot bot added the size/S label Jul 19, 2023
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Jul 19, 2023 •
edited
Loading

tested in:

@wuhuizuo wuhuizuo force-pushed the fix/tidb-check2-coverge-upload branch from 7214f35 to 5419660 Compare July 19, 2023 10:03
@wuhuizuo wuhuizuo added this to the 2023-07 milestone Jul 19, 2023
@wuhuizuo wuhuizuo self-assigned this Jul 19, 2023
@wuhuizuo
Copy link
Collaborator Author

/retest

@wuhuizuo wuhuizuo force-pushed the fix/tidb-check2-coverge-upload branch from 5419660 to af86094 Compare July 19, 2023 10:22
purelind
purelind approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 19, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-19 10:26:39.151819601 +0000 UTC m=+1105290.922158309: ☑️ agreed by purelind.

@ti-chi-bot ti-chi-bot bot added the approved label Jul 19, 2023
@wuhuizuo
Copy link
Collaborator Author

/hold

@wuhuizuo
Copy link
Collaborator Author

/retest

@wuhuizuo
Copy link
Collaborator Author

/unhold

tests are passed

@ti-chi-bot ti-chi-bot bot merged commit 2224c0f into main Jul 19, 2023
@ti-chi-bot ti-chi-bot bot deleted the fix/tidb-check2-coverge-upload branch July 19, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purelind purelind purelind approved these changes

@jayl1e jayl1e Awaiting requested review from jayl1e

Assignees

@wuhuizuo wuhuizuo

@purelind purelind

Labels
approved area/jenkins-pipelines lgtm size/S
Projects
EE - CI/CD system
Status: ✅ Done
Milestone
2023-07
Development

Successfully merging this pull request may close these issues.
2 participants
@wuhuizuo @purelind