Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: Add storage sink pipeline #1985

Merged

Conversation

CharlesCheung96
Copy link
Contributor

No description provided.

@ti-chi-bot ti-chi-bot requested review from jayl1e and purelind April 14, 2023 04:20
@ti-chi-bot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CharlesCheung96 CharlesCheung96 force-pushed the add_storage_sink_pipeline branch from 14b8913 to 0d4dc55 Compare April 19, 2023 09:24
@CharlesCheung96 CharlesCheung96 force-pushed the add_storage_sink_pipeline branch from 0d4dc55 to cd9df4f Compare April 19, 2023 09:51
Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Collaborator

[LGTM Timeline notifier]

Timeline:

  • 2023-04-19 09:58:11.487237585 +0000 UTC m=+77359.752997022: ☑️ agreed by purelind.

@ti-chi-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: CharlesCheung96, purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot merged commit f74e733 into PingCAP-QE:main Apr 19, 2023
@CharlesCheung96
Copy link
Contributor Author

ref pingcap/tiflow#8826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants