Skip to content
This repository has been archived by the owner on Dec 26, 2022. It is now read-only.

♻️ Added query params parameter to HTTP get requests #343

Merged
merged 4 commits into from
Jan 5, 2022
Merged

♻️ Added query params parameter to HTTP get requests #343

merged 4 commits into from
Jan 5, 2022

Conversation

darvil82
Copy link
Contributor

@darvil82 darvil82 commented Jan 2, 2022

Changes

  • adds: The ability to specify a params keyword argument in the HTTP get request, which will add the supplied dictionary to the query url, instead of doing it manually on each endpoint that requires this.
  • fixed: Guild.search_guild_members not working due to an incorrect variable in the request url.
  • improvements: All methods using query parameters were refactored for using this.

Check off the following

  • I have tested my changes with the current requirements
  • My Code follows the pep8 code style.

@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #343 (a35acb4) into main (88afc98) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   90.54%   90.54%           
=======================================
  Files           8        8           
  Lines          74       74           
=======================================
  Hits           67       67           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88afc98...a35acb4. Read the comment docs.

Copy link
Member

@Lunarmagpie Lunarmagpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Im pretty sure moving remove_none to the http class should be fine.

pincer/core/http.py Outdated Show resolved Hide resolved
pincer/core/http.py Outdated Show resolved Hide resolved
pincer/core/http.py Outdated Show resolved Hide resolved
pincer/core/http.py Show resolved Hide resolved
@Lunarmagpie Lunarmagpie merged commit 1054872 into Pincer-org:main Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants