Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkObserver SDK checks inconsistency resolved #996

Merged

Conversation

maharshpatel247
Copy link
Contributor

No description provided.

@PierfrancescoSoffritti PierfrancescoSoffritti changed the base branch from master to dev June 6, 2023 19:59
@PierfrancescoSoffritti
Copy link
Owner

min API for unregisterNetworkCallback is L. Why do you want to use N?

@maharshpatel247
Copy link
Contributor Author

maharshpatel247 commented Jun 7, 2023

Ohh didn't see that! I just checked the observeNetwork function and there was a check for N. SO I just added N check for destroy.

@maharshpatel247
Copy link
Contributor Author

On further investigation, I found that registerDefaultNetworkCallback has been added in N so while observing there is a check for N so while destroying too we need to check for N even though unregisterNetworkCallback is available in L

@PierfrancescoSoffritti
Copy link
Owner

You're right, thanks for finding this!

@PierfrancescoSoffritti PierfrancescoSoffritti merged commit a8d2924 into PierfrancescoSoffritti:dev Jun 8, 2023
@PierfrancescoSoffritti
Copy link
Owner

Thanks a lot for the help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants