Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method YouTubePlayer.toggleFullscreen #936

Merged
merged 5 commits into from
Mar 23, 2023
Merged

Add method YouTubePlayer.toggleFullscreen #936

merged 5 commits into from
Mar 23, 2023

Conversation

Praveen-Pable
Copy link
Contributor

Implement functionality for toggle full screen programmatically as per requirement.

@Praveen-Pable
Copy link
Contributor Author

Please find below screenshot for reference of fullscreen toggle on device orientation change

Portrait mode Landscape mode
Screenshot_1679247201 Screenshot_1679247274

PierfrancescoSoffritti
PierfrancescoSoffritti reviewed Mar 19, 2023
View reviewed changes
Copy link
Owner

@PierfrancescoSoffritti PierfrancescoSoffritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have left a few comments. I want to make sure that player.toggleFullScreen is a public API in the IFrame Player. We don't want to use internal/private stuff as it might break at anytime if YouTube decide to change the API.

core-sample-app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
core/src/main/res/raw/ayp_youtube_player.html Outdated Show resolved Hide resolved
Pierfrancesco Soffritti added 2 commits March 23, 2023 07:02
Revert to using toggleFullscreen
3f88eb8
Merge branch 'dev' into feature/auto-fullscreen-on-orientation
877d168 
# Conflicts:
#	chromecast-sender/src/main/java/com/pierfrancescosoffritti/androidyoutubeplayer/chromecast/chromecastsender/ChromecastYouTubePlayer.kt
@PierfrancescoSoffritti PierfrancescoSoffritti merged commit 694c674 into PierfrancescoSoffritti:dev Mar 23, 2023
@PierfrancescoSoffritti
Copy link
Owner

Thanks for the help @Praveen-Pable :)

@Praveen-Pable
Copy link
Contributor Author

Thanks for the help @Praveen-Pable :)

Thanks @PierfrancescoSoffritti for accepting solution 🙂👍

@PierfrancescoSoffritti PierfrancescoSoffritti changed the title feature/auto-fullscreen-on-orientation Add method YouTubePlayer.toggleFullscreen Mar 25, 2023
@PierfrancescoSoffritti PierfrancescoSoffritti mentioned this pull request Mar 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierfrancescoSoffritti PierfrancescoSoffritti PierfrancescoSoffritti left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Praveen-Pable @PierfrancescoSoffritti