Start Video without Audio Focus #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Genius to the apps that are using the library
|
Hey, thanks for the PR! can you please send it to the dev branch instead of master? I will try to review it over the weekend :) |
|
Sure thing :) |
README.md
Outdated
| @@ -29,6 +29,7 @@ A lengthier explanation to why you may want to consider using an alternative to | |||
|
|
|||
| A list of published apps that are using this library: ([let me know](https://github.com/PierfrancescoSoffritti/android-youtube-player/issues) if you want to add your app to this list) | |||
|
|
|||
| - [Genius](https://play.google.com/store/apps/details?id=com.genius.android) | |||
There was a problem hiding this comment.
mm not sure why this is here, i might have messed up when i updated the readme 😬 anyway, to keep this change clean, can you remove this line?
| } | ||
|
|
||
| /** | ||
| * Controls if the video is muted. |
There was a problem hiding this comment.
Change to something like: "Controls if the player will be initialized mute or not."
| @@ -66,6 +68,24 @@ class IFramePlayerOptions private constructor(private val playerOptions: JSONObj | |||
| return this | |||
| } | |||
|
|
|||
| /** | |||
| * Controls if the video is played automatically. | |||
There was a problem hiding this comment.
Change to something like: "Controls if the video is played automatically after the player is initialized"
|
I have removed the readme changes and changed the wording of the method descriptions 👍🏻 |
PierfrancescoSoffritti
approved these changes
Nov 5, 2022
|
Thanks for the help :) |
PierfrancescoSoffritti
added a commit
to Praveen-Pable/android-youtube-player
that referenced
this pull request
Mar 13, 2023
* Update readme (PierfrancescoSoffritti#875) Add Genius to the apps that are using the library * added mute option * added mute option * changed wording of new method descriptions * removed link in README.md Co-authored-by: Pierfrancesco Soffritti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added two options to
IFramePlayerOptions:autoplaymuteIf both of these values are initialized with 1, the video will autoplay in a muted mode without gaining Audio Focus (meaning Spotify or other background playbacks will continue). As soon as the player is unmuted with the
unMute()function, it will acquire audio focus again.I think this should fix the issues #691 and #397