Add mute / unMute functions #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request! I will review it over the weekend/next week. |
|
Nice, when do you think you can make a new release? |
|
I'll try to do it this week! worst case I'll do it over the weekend. |
|
Alright thanks |
|
Just uploaded v10.0.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the mute/unMute functions from the youtube player
This makes it possible to play a muted video, with the user having the option to unmute it by using the web ui. This wasn't possible with only
setVolumeavailable.Fixes #445
It seems this functionality was already half-implemented for the chromecast sender, see https://github.com/pierfrancescosoffritti/android-youtube-player/blob/0fe4f016016eeb02398414f996cf5207bd277d1b/chromecast-receiver/js/io/SenderMessagesDispatcher.js#L25-L28