Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with stopping playback #345

Merged
merged 2 commits into from
May 5, 2019

Conversation

hannojg
Copy link
Contributor

@hannojg hannojg commented Apr 8, 2019

When having enableBackgroundPlayback enabled the player stops sometimes when the activity gets into the background. Basically, if background playback is enabled we don't need to mind whether the activity is in fore- or background. This is a fix for it.

I currently can't compile the library on my own, so I haven't tested the changes. I assume it should be fine this way. This issue was raised since fix of issue #326

When having enableBackgroundPlayback enabled the player stopps sometimes when the activity gets into background. Basically, if background playback is enabled we don't need to mind whether the activity is in fore- or background. This is a fix for it.
@PierfrancescoSoffritti
Copy link
Owner

Hey, thanks! could you please send the PR to the dev branch instead of master? I'll try to test it during the weekend :)

@hannojg hannojg changed the base branch from master to dev April 8, 2019 20:39
@PierfrancescoSoffritti PierfrancescoSoffritti merged commit cf73ce3 into PierfrancescoSoffritti:dev May 5, 2019
@PierfrancescoSoffritti
Copy link
Owner

Hey, sorry for taking such a long time to review the PR. Just changed town and job, busy times :) thanks a lot for the help! I will release the next version some day next week!

@devbest555
Copy link

When having enableBackgroundPlayback enabled the player stops sometimes when the activity gets into the background. Basically, if background playback is enabled we don't need to mind whether the activity is in fore- or background. This is a fix for it.

I currently can't compile the library on my own, so I haven't tested the changes. I assume it should be fine this way. This issue was raised since fix of issue #326

I tried your code in my side but same error yet.
Youtube video stop playing in background sometimes.
Looking forward to chat with you ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants