Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible custom PlaybackRate implementation #1094

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

santiwanti
Copy link
Contributor

@PierfrancescoSoffritti possible implementation for #1081. This is a breaking change though. Most likely people are using things like PlaybackRate.values().forEach { it.show } which would break with this change to a sealed class.

This PR is missing a lot of work, but I didn't want to continue the implementation without getting approval that this direction is the one to go in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant