Upgrade Error Prone fork 2.36.0-picnic-1 -> 2.36.0-picnic-2 #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new release is published using GitHub Packages rather than JitPack. This comes with a simpler release setup and a (hopefully) more stable package repository. A minor downside is that GitHub Packages require authenticated access, even for read access. The documentation has been updated accordingly. The new release is no longer published using a custom groupId, enabling some build simplifications. While there, some obsolete fork-related documentation and configuration is dropped. See: - https://github.com/PicnicSupermarket/error-prone/releases/tag/v2.36.0-picnic-2 - PicnicSupermarket/error-prone@v2.36.0-picnic-1...v2.36.0-picnic-2
Stephan202
added
dependencies
chore
|
Looks good. No mutations were possible for these changes. |
Stephan202
commented
Jan 4, 2025
Comment on lines
-212
to
-213
| Pending a release of [google/error-prone#3301][error-prone-pull-3301], this | ||
| flag must currently be used in combination with `-Perror-prone-fork`. |
There was a problem hiding this comment.
This should have been deleted in the context of #685.
Comment on lines
-1647
to
-1657
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <configuration> | ||
| <systemPropertyVariables> | ||
| <!-- Property used by `ErrorProneForkTest` | ||
| to verify fork identification. --> | ||
| <error-prone-fork-in-use>true</error-prone-fork-in-use> | ||
| </systemPropertyVariables> | ||
| </configuration> | ||
| </plugin> |
There was a problem hiding this comment.
This should have been deleted in the context of #685.
|
|
Suggested commit message: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested commit message:
This is possible thanks to PicnicSupermarket/error-prone@a3aaf7c. See the README update for the requisite local changes. In the context of this work I also filed s4u/setup-maven-action#112.
NB: There's still a dependency on JitPack for
com.github.lhotari:reactor-error-prone. It appears that in the last few days JitPack is more stable again. Let's review this dependency if/when flakiness returns.