Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sensor Temperature Offset to MQTTSensor #139

Closed
stamandster opened this issue Jun 15, 2024 · 7 comments
Closed

Add Sensor Temperature Offset to MQTTSensor #139

stamandster opened this issue Jun 15, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@stamandster
Copy link

I'm not sure how to adjust the code myself, or else I'd do it. But it would be great to add the option to adjust Temp Offset just like the Onewire Sensor. Unfortunately, for things like Tasmota, sometimes the source only allows adjustment of ALL sensors on the device.

@avollkopf
Copy link
Member

If I remember correctly, this has been discussed in the past and we somehow decided to not implement it as it should be corrected at the sensor itself to avoid double correction. But I will re-review it, once I have successfully updated the brewfather api calls.

@avollkopf avollkopf added the enhancement New feature or request label Jun 18, 2024
@avollkopf avollkopf self-assigned this Jun 18, 2024
@stamandster
Copy link
Author

stamandster commented Jun 18, 2024

I appreciate that @avollkopf . I know it's not a little thing to add this, but just having the option is super helpful for me (and maybe others). It also falls inline with options of the other sensors for consistency sake. If you do adjust it (please please please!), it may be good to consider adding a little description that says something like "Be careful not to duplicate Temperature Offsets, make change here or at the sensor."

@lalo-uy
Copy link

lalo-uy commented Jun 18, 2024 via email

@stamandster
Copy link
Author

Yes, I know that is a potential, however in order to get 1s reads I need to query Status8 via HTTP at 1s interval with a python script. This is provides the existing temperature not the offset adjusted using the rule.

@lalo-uy
Copy link

lalo-uy commented Jun 18, 2024 via email

@stamandster
Copy link
Author

stamandster commented Jun 18, 2024

Yes, RIMS is the primary application. Though, another two other cases for this could be used during recirculation through the chiller for a whirl pool hop addition to make sure the incoming wort through the chiller is being adequately chilled to reach a specific whirl pool temperature. Also, I run my pump during the ramp to boil so that there's turbulence and mixture of cold/hot pockets within the liquid mass. The tele 10s period is too long in both situations.

@avollkopf
Copy link
Member

Latest version in dev branch has changes to address your request. Install version, it'll add a parameter mqtt_offset to config.yaml. Default is false. Set it manually to yes and restart cbpi -> Offset for mqtt sensor plugin is enabled. By reverting mqtt_offset to false, parameter is disabled in mqtt sensor plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants