Feature/gpiod #322
Merged
Feature/gpiod #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here the PR for the builder: Pi4J/pi4j-docker#2 |
FDelporte
reviewed
Feb 6, 2024
There was a problem hiding this comment.
Wouldn't it be easier to keep everything in one gitignore file at the root level of the project?
| * @version $Id: $Id | ||
| */ | ||
| public class GpioChip implements Closeable { | ||
| private final long cPtr; |
There was a problem hiding this comment.
I personally prefer full variable names... Same remark also for other classes with the same variable.
| @Override | ||
| protected void finalize() { | ||
| if(next == null) { | ||
| if(noCoseCurrent) { |
| @@ -52,5 +52,5 @@ chmod +x build.sh | |||
| # FOR ARMv6,ARMv7, ARMv8 32-BIT (ARMHF) | |||
| # FOR ARMv8 64-BIT (ARM64) | |||
| # ------------------------------------------------------------- | |||
| docker pull pi4j/pi4j-builder-native:2.0 | |||
| #docker pull pi4j/pi4j-builder-native:2.0 | |||
There was a problem hiding this comment.
Better to remove unused code instead of commenting it
| @@ -55,5 +55,5 @@ chmod +x build.sh | |||
| # FOR ARMv6,ARMv7, ARMv8 32-BIT (ARMHF) | |||
| # FOR ARMv8 64-BIT (ARM64) | |||
| # ------------------------------------------------------------- | |||
| docker pull pi4j/pi4j-builder-native:2.0 | |||
| #docker pull pi4j/pi4j-builder-native:2.0 | |||
| .initial(DigitalState.HIGH) | ||
| .build(); | ||
| DigitalOutput pin = pi4j.create(config); | ||
| /* |
| lastEvent.set(System.currentTimeMillis()); | ||
| }); | ||
| Thread.sleep(1000 * 60); | ||
| /* |
|
@FDelporte I applied the review comments. |
eitch
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests enables Pi4j to take advantage of the GpioD library, that gets developed together with the linux kernel.
Contents:
I'm not sure if this will immediately compile in your CI/CD pipeline. It might miss some dependencies that are needed to build the JNI library for gpiod. These are required packets: https://github.com/Pi4J/pi4j-v2/blob/501a50f1594a9bae2ea2cd794d6998db8d801faf/libraries/pi4j-library-gpiod/src/main/native/build-prerequisites.sh
Closes #321