Add new IO type and providers and interface Sensor #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FDelporte Good day. I don't see the proper way to connect this pull request to the issue 197. You have a quick pointer on doing this ? thanks Tom |
|
I'm not really sure about this PR. It brings in a specific use-case/device, something that we removed when moving from V1 to V2 to improve maintainability. What do you think @eitch @savageautomate ? |
|
Relates to #197 |
|
Determined this code change is too specific to only two sensor types. Suggested this implementation could define only the generic interfaces of possible sensor types. Suggested ENUM be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add support into the pi4j-core. It is a new IO type Sensor. also defines an interface Sensor, Config/builder and provider.
There exist https://github.com/taartspi/Pi4J_V2-TemperatureSensor This implements an I2C device that uses a BMP280 sensor, requiring this branch. This branch also documents connecting an Adafruit BMP280 to a Pi.