-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic sets #356
Dynamic sets #356
Conversation
Well, the database usage works well - inserting 20,000 rows in a single transaction is SO fast compared to doing each insert individually! |
I need to introduce a new dynamic set type: "or" sets. Example: select
id,
artistId,
title,
type
from
Product
where
(
(title = 'Product A' and artistId = 'Artist 1') or
(title = 'Product B' and artistId = 'Artist 1') or
(title = 'Product C' and artistId = 'Artist 2')
) This example is similar to |
Potential bug. I don't know for sure whether it's the responsibility of the dynamic sets to fix, but here's what I've found. In my application, I'm using Because |
Something else to chew over... insert into Product (
id,
artistId,
title
)
values ( :__dynamicValueSet ) The contents of dynamicValueSet is dynamic (well, durr). In my application, I'm building it up within a loop, and the ID is the last thing I set, meaning that the columns are no longer in the same order as how they're written in the SQL. The SQL's column order needs to match the order of the indices in the associative arrays, otherwise bad things will happen. I'm not sure how to solve this. Is there another |
This PR closes #355 and #347 - but before it will be merged, it will be tested in a live application.