Add port to connection string (#190)

* Remove boolean literal from sqlite tests * Null check of row's first field * Add missing port configuration in connection string
PhpGt · Jul 5, 2020 · 96cb700 · 96cb700
1 parent 5ed2225
commit 96cb700
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/Connection/Settings.php b/src/Connection/Settings.php
@@ -131,6 +131,7 @@ public function getConnectionString():string {
 
 		default:
 			$connectionString .= "host=" . $this->getHost();
+			$connectionString .= ";port=" . $this->getPort();
 			$connectionString .= ";dbname=" . $this->getSchema();
 			$connectionString .= ";charset=" . self::CHARSET;
 			break;

diff --git a/test/unit/Connection/SettingsTest.php b/test/unit/Connection/SettingsTest.php
@@ -132,6 +132,8 @@ public function testGetConnectionString() {
 			$this->properties["driver"],
 			":host=",
 			$this->properties["host"],
+			";port=",
+			$this->properties["port"],
 			";dbname=",
 			$this->properties["database"],
 			";charset=",