-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added constructor overload to PhotonCameraSim for AprilTagFieldLayout #1692
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, assuming this does what ya need it to now
photon-lib/src/main/java/org/photonvision/simulation/PhotonCameraSim.java
Outdated
Show resolved
Hide resolved
Do we want Python and C++ to have this as well? |
We should probably keep api parity, yeah |
@JochemvdBroek are you happy to do Python and C++ or would you like help with it? |
@spacey-sooty, I am not familiar enough with c++ to make these changes, so it would be a big help if you could look at it. Could you then also change the tagLayout back to final? |
Not an issue, thanks for opening a PR and detailed issue :) |
photon-lib/src/main/native/include/photon/simulation/PhotonCameraSim.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Closes #1691