Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added constructor overload to PhotonCameraSim for AprilTagFieldLayout #1692

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

JochemvdBroek
Copy link
Contributor

@JochemvdBroek JochemvdBroek commented Jan 8, 2025

Closes #1691

@JochemvdBroek JochemvdBroek requested a review from a team as a code owner January 8, 2025 15:10
Copy link
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, assuming this does what ya need it to now

@spacey-sooty
Copy link
Member

Seems reasonable, assuming this does what ya need it to now

Do we want Python and C++ to have this as well?

@mcm001
Copy link
Contributor

mcm001 commented Jan 8, 2025

We should probably keep api parity, yeah

@spacey-sooty
Copy link
Member

spacey-sooty commented Jan 8, 2025

@JochemvdBroek are you happy to do Python and C++ or would you like help with it?

@JochemvdBroek
Copy link
Contributor Author

@spacey-sooty, I am not familiar enough with c++ to make these changes, so it would be a big help if you could look at it. Could you then also change the tagLayout back to final?

@spacey-sooty
Copy link
Member

@spacey-sooty, I am not familiar enough with c++ to make these changes, so it would be a big help if you could look at it. Could you then also change the tagLayout back to final?

Not an issue, thanks for opening a PR and detailed issue :)

@spacey-sooty spacey-sooty requested a review from mcm001 January 8, 2025 16:13
@mcm001 mcm001 merged commit cc740c9 into PhotonVision:main Jan 8, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AprilTagLayout should be configurable in PhotonCameraSim
3 participants