-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom models #1687
Add custom models #1687
Conversation
General UI Refinements (PhotonVision#1678)
Fix Working on the Wrong Branch
Someone should test that the files upload properly on a PI, I haven't tested it on that platform as I don't have one readily available. |
Do you think this would make sense as its own card on the settings page instead of piled in with all the other buttons? |
I think that would also work. My reasoning was that these were files that would go on the device, so I put it in there. I can make it a separate card tho, that's not much work. |
…on into add-custom-models
…on into add-custom-models
…on into add-custom-models
…on into add-custom-models
…on into add-custom-models
…on into add-custom-models
fixes #1354 |
…on into add-custom-models
…on into add-custom-models
…on into add-custom-models
@mcm001 this should be good to go |
Quick test on pi3, looks like the upload card is visible and "works" in the context it accepts files. The front-end camera interface uses this logic to disallow selecting object detection when there's no backend for it available, is it possible to use the same mechanism on the settings page to hide the upload card on platforms where it can't be run? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wheeeeee
This allows for uploading of custom object detection models via the GUI.
Note #1685 ought to be merged prior to this one, as it contains the same edits.