Improve error message when trying to create shortcut to executable outside container #2356

plata · 2021-01-27T16:21:10Z

…tside container

madoar

I think we will need to reconfigure the Checkstyle Job. The findings here are kind of annoying.

madoar · 2021-01-31T11:07:33Z

...avafx/src/main/java/org/phoenicis/javafx/components/library/control/LibraryFeaturePanel.java

+
+                errorDialog.showAndWait();
+            });
+            return;


Can we move the remaining code of this method to a new method?
I don't like the return; here, we could try to replace it with an if ... else ... syntax.
What do you think?

madoar · 2021-04-05T20:56:13Z

@plata how is the current state of this PR?

plata · 2021-04-07T14:32:05Z

Changed to if ... else. I don't see too much use in moving part of the code to a separate method.

plata added 2 commits January 27, 2021 17:19

Improve error message when trying to create shortcut to executable ou…

c7dcac4

…tside container

Remove debug code

c3d58b5

madoar reviewed Jan 31, 2021

View reviewed changes

Use if ... else

484a7a6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve error message when trying to create shortcut to executable outside container #2356

Improve error message when trying to create shortcut to executable outside container #2356

plata commented Jan 27, 2021

madoar left a comment

madoar Jan 31, 2021

madoar commented Apr 5, 2021

plata commented Apr 7, 2021

Improve error message when trying to create shortcut to executable outside container #2356

Are you sure you want to change the base?

Improve error message when trying to create shortcut to executable outside container #2356

Conversation

plata commented Jan 27, 2021

madoar left a comment

Choose a reason for hiding this comment

madoar Jan 31, 2021

Choose a reason for hiding this comment

madoar commented Apr 5, 2021

plata commented Apr 7, 2021